Re: [Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Zeeshan Ali (Khattak)
On Fri, May 13, 2016 at 5:56 PM, Daniel P. Berrange wrote: > On Fri, May 13, 2016 at 05:35:15PM +0100, Zeeshan Ali (Khattak) wrote: >> Hi Daniel, >> >> Thanks for the very long explanation (I especially appreciated the >> ascii-art diagram) but I don't quite agree. >> >> While I don't see any harm

Re: [Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2016 at 05:35:15PM +0100, Zeeshan Ali (Khattak) wrote: > Hi Daniel, > > Thanks for the very long explanation (I especially appreciated the > ascii-art diagram) but I don't quite agree. > > While I don't see any harm in -db not depending on libosinfo, I really > don't see the benef

Re: [Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Zeeshan Ali (Khattak)
Hi Daniel, Thanks for the very long explanation (I especially appreciated the ascii-art diagram) but I don't quite agree. While I don't see any harm in -db not depending on libosinfo, I really don't see the benefit of going as far as to providing a separate package for db tools. The -db does not

Re: [Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Daniel P. Berrange
On Fri, May 13, 2016 at 04:24:52PM +0100, Zeeshan Ali (Khattak) wrote: > Hi Daniel, > > On Fri, May 13, 2016 at 12:56 PM, Daniel P. Berrange > wrote: > > As mentioned previously we need to split off the database > > from the main libosinfo library. In order todo so, we need > > some tools to mana

Re: [Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Zeeshan Ali (Khattak)
Hi Daniel, On Fri, May 13, 2016 at 12:56 PM, Daniel P. Berrange wrote: > As mentioned previously we need to split off the database > from the main libosinfo library. In order todo so, we need > some tools to manage the database. One of those is the > pre-existing osinfo-db-validate command, but i

[Libosinfo] [osinfo-db-tools 1/2] Fix build system after creating initial repository

2016-05-13 Thread Daniel P. Berrange
The initial repository state was created from libosinfo GIT at revision: commit 501541a336cd29d3da48584f022ce329fef418dd Author: Fabiano Fidêncio Date: Thu May 12 18:54:58 2016 +0200 win,installer: Fix "Windwos" typo It was initialized using the following commands: $ git clone lib

[Libosinfo] [osinfo-db-tools 0/2] Start new osinfo-db-tools package

2016-05-13 Thread Daniel P. Berrange
As mentioned previously we need to split off the database from the main libosinfo library. In order todo so, we need some tools to manage the database. One of those is the pre-existing osinfo-db-validate command, but in future it will be joined by osinfo-db-import & osinfo-db-export to let admins i

[Libosinfo] [PATCH] Remove osinfo-db-validate tool

2016-05-13 Thread Daniel P. Berrange
A new osinfo-db-tools package has been forked off from the libosinfo package. This contains the osinfo-db-validate tool, so it is no longer neccessary to include it here. Signed-off-by: Daniel P. Berrange --- .gitignore | 3 - libosinfo.spec.in | 3 +- mingw-libosinf

Re: [Libosinfo] [PATCH v2] debian: Add Debian Testing info

2016-05-13 Thread Christophe Fergeau
On Fri, May 13, 2016 at 12:54:33PM +0200, Fabiano Fidêncio wrote: > Is worth to mention that Debian Testing is a rolling release done every It is worth mentioning > week. That's the reason the upgrades/derives-from fields are ommited in omitted Acked-by: Christophe Fergeau Christophe signat

[Libosinfo] [PATCH v2] debian: Add Debian Testing info

2016-05-13 Thread Fabiano Fidêncio
Is worth to mention that Debian Testing is a rolling release done every week. That's the reason the upgrades/derives-from fields are ommited in this patch. Signed-off-by: Fabiano Fidêncio --- data/os/debian.org/debian-testing.xml.in | 50 ++ po/POTFILES.in

Re: [Libosinfo] [PATCH] debian: Add Debian testing info

2016-05-13 Thread Christophe Fergeau
Hey, Ah, I thought this would treat testing as a pre-release for debian-stable.next (dunno what its name will be), but this actually treats debian-testing as some kind of rolling release. On Wed, May 11, 2016 at 10:56:30PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- >

Re: [Libosinfo] [PATCH 1/2] win, installer: Fix misplaced parenthesis

2016-05-13 Thread Fabiano Fidêncio
On Fri, May 13, 2016 at 9:58 AM, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau Pushed, thanks! > > On Thu, May 12, 2016 at 11:01:24PM +0200, Fabiano Fidêncio wrote: >> The commit 17809d54 inserted a wrong parenthesis in the test done for >> skipping the ProductKey during the Window

Re: [Libosinfo] [PATCH 2/2] win,installer: Fix "Windwos" typo

2016-05-13 Thread Fabiano Fidêncio
On Fri, May 13, 2016 at 9:58 AM, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau Pushed, thanks! > > On Thu, May 12, 2016 at 11:01:25PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio >> --- >> data/install-script/microsoft.com/windows-unattend-desktop.xml.in | 2

Re: [Libosinfo] [PATCH 1/2] win, installer: Fix misplaced parenthesis

2016-05-13 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, May 12, 2016 at 11:01:24PM +0200, Fabiano Fidêncio wrote: > The commit 17809d54 inserted a wrong parenthesis in the test done for > skipping the ProductKey during the WindowsPE phase of the script. > > In this patch, the bogus expression "count(media/variant

Re: [Libosinfo] [PATCH 2/2] win,installer: Fix "Windwos" typo

2016-05-13 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, May 12, 2016 at 11:01:25PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/install-script/microsoft.com/windows-unattend-desktop.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/data/install-s