[libmicrohttpd] tsearch updates from NetBSD source

2019-11-27 Thread ng0
Hi, is this okay for merge? I took it from our (NetBSD) tree, compared to what libmicrohttpd contains. diff --git a/src/lib/tsearch.c b/src/lib/tsearch.c index 78f37608..2d374cad 100644 --- a/src/lib/tsearch.c +++ b/src/lib/tsearch.c @@ -12,6 +12,9 @@ #include "tsearch.h" #include +#ifndef _

Re: [libmicrohttpd] tsearch updates from NetBSD source

2019-11-27 Thread Evgeny Grin
This could cause a problem on platforms where size of unsigned long is smaller than size of pointer. Windows x64 is obvious example. -- Best Wishes,Evgeny Grin   27.11.2019, 14:47, "ng0" :Hi,is this okay for merge? I took it from our (NetBSD) tree,compared to what libmicrohttpd contains.diff --git

Re: [libmicrohttpd] tsearch updates from NetBSD source

2019-11-27 Thread ng0
Okay, thanks. What about the != 0 addition, could this be problematic as well?

Re: [libmicrohttpd] tsearch updates from NetBSD source

2019-11-27 Thread Evgeny Grin
Let's stay with current version. '!= 0' will not add any improvement.Unpatched version gives maintenance simplicity. -- Best Wishes,Evgeny Grin   27.11.2019, 16:53, "ng0" :Okay, thanks.What about the != 0 addition, could this be problematic as well? 

Re: [libmicrohttpd] tsearch updates from NetBSD source

2019-11-27 Thread ng0
Okay. Thanks for reviewing the patch.

[libmicrohttpd] How to get the client IP as IPv4 in dual stack mode?

2019-11-27 Thread silvioprog
Hi. I have a function which checks if the sa_family is AF_INET or AF_INET6 and formats the client address as IPv4 (e.g. 127.0.0.1) or IPv6 (e.g. ::1) into a string. However, when I enable the dual stack in MHD, it always returns AF_INET6 in sa_family even when passing -4 as parameter in curl. I'm