Re: [libmicrohttpd] Freeing data added to MHD_create_response_from_buffer

2022-01-17 Thread Gavin Henry
Awesome. All leaks are now gone! Thank you Nicolas.

Re: [libmicrohttpd] Freeing data added to MHD_create_response_from_buffer

2022-01-17 Thread Gavin Henry
mode at: https://www.gnu.org/software/libmicrohttpd/

Re: [libmicrohttpd] Freeing data added to MHD_create_response_from_buffer

2022-01-17 Thread Gavin Henry
> > If I understand your code, you use MHD_create_response_from_buffer > with the MHD_RESPMEM_PERSISTENT mode, which, according to the > documentation [1], means that 'reply' should be static/global, which isn't. > > You can either: > - use MHD_RESPMEM_MUST_FREE and let MHD free 'reply' after use

Re: [libmicrohttpd] Freeing data added to MHD_create_response_from_buffer

2022-01-17 Thread Nicolas Mora
Hello Gavin, [resend to the list, sorry fot the noise Gavin] Le 2022-01-17 à 14 h 40, Gavin Henry a écrit :> Hi all, > > I'm using json_dumps from jansson in my MHD_create_response_from_buffer > > Where is the best place to free this? I've tried at the end of my responses: > > MHD_destroy_resp

[libmicrohttpd] Freeing data added to MHD_create_response_from_buffer

2022-01-17 Thread Gavin Henry
Hi all, I'm using json_dumps from jansson in my MHD_create_response_from_buffer Where is the best place to free this? I've tried at the end of my responses: MHD_destroy_response(response); free(json_reply) return ret; but this obviously breaks the data that goes to the client: https://github.c

Re: [libmicrohttpd] Digest Authentication algorithm field case sensitivity

2022-01-17 Thread Evgeny Grin
Values must match precisely what is specified by RFC, so this fix definitely is an improvement. However, it is not absolutely clear whether case-sensitive or case-insensitive match should be used for parameters and values. The initial RFC2617 specified that: * realm token must be case-insensi

Re: [libmicrohttpd] Digest Authentication algorithm field case sensitivity

2022-01-17 Thread Christian Grothoff
Dear Ahmet, Thanks for the report, I've fixed this in Git master now. -Christian On 17.01.22 09:50, Ahmet Kermen wrote: > Hi All, > > Since version 0.9.62 libmicrohttpd appears to be started adding optional > "algorithm" field for digest authentication header. According to > RFC2617 https://da

[libmicrohttpd] Digest Authentication algorithm field case sensitivity

2022-01-17 Thread Ahmet Kermen
Hi All, Since version 0.9.62 libmicrohttpd appears to be started adding optional "algorithm" field for digest authentication header. According to RFC2617 https://datatracker.ietf.org/doc/html/rfc2617 and RFC7616 https://datatracker.ietf.org/doc/h