[Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
Hi Eric, a couple of POSIX questions for you from nbdkit. The first question is from an AUR comment on nbdkit: https://aur.archlinux.org/packages/nbdkit#comment-937381 I think there's a bash-ism in the logscript parameter in this test: https://gitlab.com/nbdkit/nbdkit/-/blame/master/tests/

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Laszlo Ersek
On 10/9/23 09:46, Richard W.M. Jones wrote: > Hi Eric, a couple of POSIX questions for you from nbdkit. > > The first question is from an AUR comment on nbdkit: > > https://aur.archlinux.org/packages/nbdkit#comment-937381 > > I think there's a bash-ism in the logscript parameter in this test:

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
On Mon, Oct 09, 2023 at 12:57:14PM +0200, Laszlo Ersek wrote: > On 10/9/23 09:46, Richard W.M. Jones wrote: > > Hi Eric, a couple of POSIX questions for you from nbdkit. > > > > The first question is from an AUR comment on nbdkit: > > > > https://aur.archlinux.org/packages/nbdkit#comment-937381

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Laszlo Ersek
On 10/9/23 13:12, Richard W.M. Jones wrote: > On Mon, Oct 09, 2023 at 12:57:14PM +0200, Laszlo Ersek wrote: >> On 10/9/23 09:46, Richard W.M. Jones wrote: >>> Hi Eric, a couple of POSIX questions for you from nbdkit. >>> >>> The first question is from an AUR comment on nbdkit: >>> >>> https://aur

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
On Mon, Oct 09, 2023 at 01:32:07PM +0200, Laszlo Ersek wrote: > On 10/9/23 13:12, Richard W.M. Jones wrote: > > On Mon, Oct 09, 2023 at 12:57:14PM +0200, Laszlo Ersek wrote: > >> On 10/9/23 09:46, Richard W.M. Jones wrote: > >>> Hi Eric, a couple of POSIX questions for you from nbdkit. > >>> > >>>

Re: [Libguestfs] [nbdkit] Two POSIX questions for you ...

2023-10-09 Thread Richard W.M. Jones
So one thing we could do for this test is to require (for the test) that /bin/sh is bash, something like the patch below. I was only able to test this in the positive case. diff --git a/tests/test-log-script-info.sh b/tests/test-log-script-info.sh index fa9b2ed32..d65f6415d 100755 --- a/tests/t