Re: [Libguestfs] [PATCH v7 12/12] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-10-05 Thread Eric Blake
On Wed, Oct 04, 2023 at 04:55:02PM -0500, Eric Blake wrote: > > > +static int > > > +nbd_co_block_status_payload_read(NBDClient *client, NBDRequest *request, > > > + Error **errp) > > > > [..] > > > +for (i = 0; i < count; i++) { > > > +id = ldl_be_p(bu

Re: [Libguestfs] [PATCH v7 12/12] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-10-05 Thread Vladimir Sementsov-Ogievskiy
On 05.10.23 16:49, Eric Blake wrote: On Wed, Oct 04, 2023 at 04:55:02PM -0500, Eric Blake wrote: +static int +nbd_co_block_status_payload_read(NBDClient *client, NBDRequest *request, + Error **errp) [..] +for (i = 0; i < count; i++) { +id = ldl_be

Re: [Libguestfs] [PATCH v7 12/12] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-10-05 Thread Vladimir Sementsov-Ogievskiy
On 25.09.23 22:22, Eric Blake wrote: Allow a client to request a subset of negotiated meta contexts. For example, a client may ask to use a single connection to learn about both block status and dirty bitmaps, but where the dirty bitmap queries only need to be performed on a subset of the disk;

Re: [Libguestfs] [PATCH v7 12/12] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-10-05 Thread Eric Blake
On Thu, Oct 05, 2023 at 05:33:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > +static int > > +nbd_co_block_status_payload_read(NBDClient *client, NBDRequest *request, > > + Error **errp) > > +{ > > +int payload_len = request->len; > > payload_len should be

Re: [Libguestfs] [PATCH v7 01/12] nbd/server: Support a request payload

2023-10-05 Thread Eric Blake
On Mon, Sep 25, 2023 at 02:22:31PM -0500, Eric Blake wrote: > Upcoming additions to support NBD 64-bit effect lengths allow for the > possibility to distinguish between payload length (capped at 32M) and > effect length (64 bits, although we generally assume 63 bits because > of off_t limitations).

Re: [Libguestfs] [PATCH v7 01/12] nbd/server: Support a request payload

2023-10-05 Thread Vladimir Sementsov-Ogievskiy
On 05.10.23 18:38, Eric Blake wrote: On Mon, Sep 25, 2023 at 02:22:31PM -0500, Eric Blake wrote: Upcoming additions to support NBD 64-bit effect lengths allow for the possibility to distinguish between payload length (capped at 32M) and effect length (64 bits, although we generally assume 63 bit