On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote:
> Should have done this a long time ago. I feel it is about time we
> change the default of nbdkit --run to imply -U -, rather than opening
> a public port.
>
> Patch series turned out to be a little bit more complicated than I
>
On Mon, Sep 11, 2023 at 07:08:48AM -0500, Eric Blake wrote:
> On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote:
> > Should have done this a long time ago. I feel it is about time we
> > change the default of nbdkit --run to imply -U -, rather than opening
> > a public port.
> >
Hi ,
Yes, was mounting one disk using libguestfs version 1.38 but the disk
filesystem type is unknown, can't it be possible to mount unknown filesystem
type disk?
Thanks
Teja K
-Original Message-
From: Richard W.M. Jones
Sent: Wednesday, September 6, 2023 4:50 PM
To: Teja Konapalli
Pipeline #999620528 has failed!
Project: libnbd ( https://gitlab.com/nbdkit/libnbd )
Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master )
Commit: f07d48ff (
https://gitlab.com/nbdkit/libnbd/-/commit/f07d48ff547643bd4cff014b803c609d4ded2dd8
)
Commit Message: interop: Skip tests
On Mon, Sep 11, 2023 at 12:18:21PM +, Teja Konapalli wrote:
> Hi ,
>
> Yes, was mounting one disk using libguestfs version 1.38 but the
> disk filesystem type is unknown, can't it be possible to mount
> unknown filesystem type disk?
This might not be related to the version of libguestfs, since
On Sun, Sep 10, 2023 at 11:34:22AM +0100, Richard W.M. Jones wrote:
> This message got caught in moderation because the attachment
> was large. I put the attachment here:
>
> http://oirase.annexia.org/tmp/2023-lgarrett-virt-v2v-debug-output.txt
>
> - Forwarded message from Lee Garrett -
On Mon, Sep 11, 2023 at 01:11:46PM +0100, Richard W.M. Jones wrote:
> On Mon, Sep 11, 2023 at 07:08:48AM -0500, Eric Blake wrote:
> > On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote:
> > > Should have done this a long time ago. I feel it is about time we
> > > change the default
On Sat, Sep 09, 2023 at 02:57:49PM +0100, Richard W.M. Jones wrote:
> Previously there were two places where similiar-ish logic was used to
> decide if we are going to serve over a socket activation, -s, Unix
> socket, AF_VSOCK or TCP/IP. Let's abstract that into a service_mode.
>
> One place whe
On Sat, Sep 09, 2023 at 02:57:50PM +0100, Richard W.M. Jones wrote:
> Reduce long-range code dependencies by not setting export_name in
> run_command (--run functionality), especially as this function is not
> always called.
>
> If the -e option was not used at all then export_name will be NULL.
>
On Mon, Sep 11, 2023 at 08:18:04AM -0500, Eric Blake wrote:
> On Mon, Sep 11, 2023 at 01:11:46PM +0100, Richard W.M. Jones wrote:
> > On Mon, Sep 11, 2023 at 07:08:48AM -0500, Eric Blake wrote:
> > > On Sat, Sep 09, 2023 at 02:57:48PM +0100, Richard W.M. Jones wrote:
> > > > Should have done this a
On Sat, Sep 09, 2023 at 02:57:51PM +0100, Richard W.M. Jones wrote:
> This removes another long-range code dependency.
> ---
> server/sockets.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On Sat, Sep 09, 2023 at 02:57:52PM +0100, Richard W.M. Jones wrote:
> Move the calculation of $uri to the main function (well, inlined
> there), and out of --run code.
>
> This is largely code motion. In theory it changes the content of $uri
> since we now shell quote it after generating it, but
On Sat, Sep 09, 2023 at 02:57:53PM +0100, Richard W.M. Jones wrote:
> Example after applying this patch:
>
> $ ./nbdkit -fv --port -e foo null 1M
> /home/rjones/d/nbdkit/server/nbdkit -f -v --port= -e foo --
> /home/rjones/d/nbdkit/plugins/null/.libs/nbdkit-null-plugin.so 1M
> nbdk
On Mon, Sep 11, 2023 at 09:01:47AM -0500, Eric Blake wrote:
> On Sat, Sep 09, 2023 at 02:57:52PM +0100, Richard W.M. Jones wrote:
> > Move the calculation of $uri to the main function (well, inlined
> > there), and out of --run code.
> >
> > This is largely code motion. In theory it changes the c
On Mon, Sep 11, 2023 at 09:04:13AM -0500, Eric Blake wrote:
> Do we also want to output a debug statement when a URI is not
> possible, such as under -s?
Yes, I'll add something for those two cases.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my p
On Mon, Sep 11, 2023 at 03:09:21PM +0100, Richard W.M. Jones wrote:
> > > - case SERVICE_MODE_UNIXSOCKET:
> > > -fprintf (fp, "nbd%s+unix://", tls == 2 ? "s" : "");
> > > -if (export_name && strcmp (export_name, "") != 0) {
> > > - putc ('/', fp);
> > > - uri_quote (export_name,
On Sat, Sep 09, 2023 at 02:57:54PM +0100, Richard W.M. Jones wrote:
> Almost always when you used nbdkit --run you should also use -U - (to
> use a private Unix domain socket). Otherwise nbdkit listened on TCP
> port 10809, which had two bad side effects: It permitted other
> processes to interfer
On Sat, Sep 09, 2023 at 02:57:55PM +0100, Richard W.M. Jones wrote:
> ---
> tests/test-parallel-file.sh | 1 -
> tests/test-parallel-nbd.sh | 1 -
> tests/test-parallel-sh.sh | 1 -
> 3 files changed, 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat,
On Mon, Sep 11, 2023 at 09:19:12AM -0500, Eric Blake wrote:
> On Mon, Sep 11, 2023 at 03:09:21PM +0100, Richard W.M. Jones wrote:
> > > > - case SERVICE_MODE_UNIXSOCKET:
> > > > -fprintf (fp, "nbd%s+unix://", tls == 2 ? "s" : "");
> > > > -if (export_name && strcmp (export_name, "") != 0)
On Sat, Sep 09, 2023 at 02:57:56PM +0100, Richard W.M. Jones wrote:
> This requires that nbdkit is built with the --run feature, which
> (currently) is not true for Windows. (In some tests we separately
> checked for !Windows, but let's favour consistency.)
> ---
> plugins/rust/test-ramdisk.sh
On Sat, Sep 09, 2023 at 02:57:57PM +0100, Richard W.M. Jones wrote:
> In tests where we used 'nbdkit -U - ... --run', remove -U - as that is
> now implicit.
> ---
> tests/Makefile.am| 2 +-
Also big, but likewise useful. (We'll still have to use explicit -U-
in libnbd for
On Sat, Sep 09, 2023 at 02:57:58PM +0100, Richard W.M. Jones wrote:
> XXX NOTE XXX
>
> I would not apply this patch immediately, since online documentation
> will get updated as soon as I do that. Best to wait until after 1.36
> is released at least.
At the earliest, on the day that we are ready
On Mon, Sep 11, 2023 at 09:34:50AM -0500, Eric Blake wrote:
> On Sat, Sep 09, 2023 at 02:57:58PM +0100, Richard W.M. Jones wrote:
> > XXX NOTE XXX
> >
> > I would not apply this patch immediately, since online documentation
> > will get updated as soon as I do that. Best to wait until after 1.36
This series, minus the delayed documentation patch, plus the
--dump-config patch, was pushed as:
ff3c9eb0e..868954b23
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets y
Hi,
On 11.09.23 15:13, Richard W.M. Jones wrote:
On Sun, Sep 10, 2023 at 11:34:22AM +0100, Richard W.M. Jones wrote:
This message got caught in moderation because the attachment
was large. I put the attachment here:
http://oirase.annexia.org/tmp/2023-lgarrett-virt-v2v-debug-output.txt
-
If we suspect that the whole firstboot mechanism might not be working
with the new version of Windows, one way to test it (on this one, or a
freshly installed Windows VM) would be:
$ virt-customize -a windows.img --firstboot-command 'echo hello'
and see if "hello" is written in some form to t
Hi Richard & Team,
Am getting below issue frequently when I try to mount using libguestfs.
[ 2023-09-12 08:17:43 ] errno: ( 0 ) : mount_local: unknown option 1804310928
(this can happen if a program is compiled against a newer version of
libguestfs, then dynamically linked to an older version)
27 matches
Mail list logo
