On Tue, May 30, 2023 at 05:48:25PM +0200, Laszlo Ersek wrote:
> BTW I'm foreseeing a problem: if the extended block descriptor can
> provide an unsigned 64-bit length, we're going to have trouble exposing
> that in OCaml, because OCaml only has signed 64-bit integers. So that's
> going to reproduce
On Thu, May 25, 2023 at 08:00:50AM -0500, Eric Blake wrote:
> Support sending 64-bit requests if extended headers were negotiated.
> This includes setting NBD_CMD_FLAG_PAYLOAD_LEN any time we send an
> extended NBD_CMD_WRITE; this is such a fundamental part of the
> protocol that for now it is easi
On Wed, May 31, 2023 at 05:46:55PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 15.05.23 22:53, Eric Blake wrote:
> > Time to support clients that request extended headers. Now we can
> > finally reach the code added across several previous patches.
> >
> > Even though the NBD spec has been al
On Tue, Jun 06, 2023 at 08:06:50PM +0100, Richard W.M. Jones wrote:
>
> Michael Henriksen pointed out an issue with this approach.
>
> If the web server is actually generating the content on the fly then
> it may send it as chunked encoding, and in HTTP/1.1 it's not required
> that the Content-Le
On 5/25/23 15:00, Eric Blake wrote:
> The existing nbd_block_status() callback is permanently stuck with an
> array of uint32_t pairs (len/2 extents), which is both constrained on
(
so the terminology is:
- we have "len" uint32_t elements in the array,
- one extent is one uint32_t pair,
- henc
On Thu, Jun 01, 2023 at 11:04:05AM +0200, Laszlo Ersek wrote:
> On 5/25/23 15:00, Eric Blake wrote:
> > @@ -69,11 +75,18 @@ REPLY.STRUCTURED_REPLY.RECV_REMAINING:
> > REPLY.STRUCTURED_REPLY.CHECK:
> >struct command *cmd = h->reply_cmd;
> >uint16_t flags, type;
> > - uint32_t length;
> >
I don't want to actually link to them to avoid giving them link-karma,
but the old repositories / now mirrors at:
github.com/libguestfs/libnbd
github.com/libguestfs/nbdkit
stopped mirroring the true repositories:
https://gitlab.com/nbdkit/libnbd
https://gitlab.com/nbdkit/nbdkit
some months ago.
The subject lines are confusing: 9/14 enables extended headers in the
server, while this one does not yet enable the headers but is merely a
preliminary step. I'll probably retitle one or the other in v4.
On Wed, May 31, 2023 at 06:26:17PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 15.05.23
On Wed, Jun 07, 2023 at 07:18:46PM +0100, Richard W.M. Jones wrote:
> I don't want to actually link to them to avoid giving them link-karma,
> but the old repositories / now mirrors at:
>
> github.com/libguestfs/libnbd
> github.com/libguestfs/nbdkit
>
> stopped mirroring the true repositories:
>
