Re: [Libguestfs] [libnbd PATCH v2] tests/requires: wrap source code at 80 characters

On 4/19/23 20:21, Eric Blake wrote: > On Wed, Apr 19, 2023 at 05:31:27PM +0200, Laszlo Ersek wrote: >> Embedding a shell script in a multi-line C string literal is an exercise >> in pain. I can see why the original author (whom I shall not look up with >> git-blame :) ) went for the easy route. Sti

[Libguestfs] libnbd | Failed pipeline for master | 86820dba

Pipeline #843086450 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 86820dba ( https://gitlab.com/nbdkit/libnbd/-/commit/86820dbab49723d8ce3182fb0b94f3006f151b57 ) Commit Message: tests/requires: wra

Re: [Libguestfs] libnbd | Failed pipeline for master | 86820dba

On 4/20/23 10:52, GitLab wrote: > GitLab > ✖ Pipeline #843086450 has failed! > >   > Project nbdkit / libnbd > > Branch > master > > Commit > 86

[Libguestfs] [libnbd PATCH 0/3] start wrapping generated C source code harder at 80 chars

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 This is my first stab at wrapping generated C source code "harder" at 80 characters. The first two patches only tweak "scripts/git.orderfile". The last patch modifies the generator. I'm posting the last patch effectively in isolation (f

[Libguestfs] [libnbd PATCH 1/3] scripts/git.orderfile: drop "generator/generator"

Since commit 33f6d55891f2 ("generator: Split the generator script into separate files and compile it.", 2020-02-29), "generator/generator" has been a binary file and has not been tracked under version control; the commit even added "generator/generator" to ".gitignore". Therefore, we don't expect "

[Libguestfs] [libnbd PATCH 2/3] scripts/git.orderfile: put *.mli first among generator files

Similarly to how we put *.h (i.e., interface) files first among C-language source code, move *.mli to the top of the (OCaml-language) generator files in patches. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 Signed-off-by: Laszlo Ersek --- scripts/git.orderfile | 1 + 1 file chan

[Libguestfs] [libnbd PATCH 3/3] generator: indent C argument list 2 spaces relative to function designator

Change the optional "parens" parameter of "print_arg_list" from bool to a new union type. The new union type has three data constructors, NoParens (matching the previous "false" value), ParensSameLine (matching the previous "true" value), and a third constructor called "ParensNewLine", which wraps

Re: [Libguestfs] [libnbd PATCH 3/3] generator: indent C argument list 2 spaces relative to function designator

On Thu, Apr 20, 2023 at 04:04:58PM +0200, Laszlo Ersek wrote: > Change the optional "parens" parameter of "print_arg_list" from bool to a > new union type. The new union type has three data constructors, NoParens > (matching the previous "false" value), ParensSameLine (matching the > previous "true

Re: [Libguestfs] [libnbd PATCH 1/3] scripts/git.orderfile: drop "generator/generator"

On Thu, Apr 20, 2023 at 04:04:56PM +0200, Laszlo Ersek wrote: > Since commit 33f6d55891f2 ("generator: Split the generator script into > separate files and compile it.", 2020-02-29), "generator/generator" has > been a binary file and has not been tracked under version control; the > commit even add

Re: [Libguestfs] [libnbd PATCH 2/3] scripts/git.orderfile: put *.mli first among generator files

On Thu, Apr 20, 2023 at 04:04:57PM +0200, Laszlo Ersek wrote: > Similarly to how we put *.h (i.e., interface) files first among C-language > source code, move *.mli to the top of the (OCaml-language) generator > files in patches. > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 >

Re: [Libguestfs] [libnbd PATCH 3/3] generator: indent C argument list 2 spaces relative to function designator

On 4/20/23 16:36, Richard W.M. Jones wrote: > On Thu, Apr 20, 2023 at 04:04:58PM +0200, Laszlo Ersek wrote: >> Change the optional "parens" parameter of "print_arg_list" from bool to a >> new union type. The new union type has three data constructors, NoParens >> (matching the previous "false" valu