Re: [Libguestfs] [PATCH] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

On 12/20/22 21:57, Andrey Drobyshev wrote: > On 12/20/22 11:51, Laszlo Ersek wrote: >> On 12/19/22 23:16, Andrey Drobyshev wrote: >> >>> Now I'm a bit confused myself as a result of our discussion: should we >>> really give priority to BIOS Boot partition? Because I tried to >>> replay the opposit

Re: [Libguestfs] [V2V PATCH v5] parse_libvirt_xml: look for manual firmware in "/domain/os/loader/@type"

On 12/20/22 16:01, Andrey Drobyshev wrote: > According to [1], there're different ways to specify which firmware is > to be used by a libvirt-driven VM. Namely, there's an automatic > firmware selection, e.g.: > > ... > > ... > > and a manual one, e.g.: > > ... > >

[Libguestfs] [V2V PATCH v2 1/2] inspect: use List.fold_left to iterate over partitions

This patch is merely a refactoring and does not introduce any changes in behaviour. It's used as a prelude for the next patch which prioritizes BIOS boot partition when searching for the right firmware. Co-authored-by: Laszlo Ersek Signed-off-by: Andrey Drobyshev --- convert/inspect_source.ml

[Libguestfs] [V2V PATCH v2 2/2] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

If the guest uses BIOS firmware but GPT partitioned disk, v2v inspection might fail to correctly detect the firmware being used by the source mathine. Namely, consider the following GPT partition table: Number Start (sector)End (sector) Size Code Name 120484

[Libguestfs] [V2V PATCH v2 0/2] inspect: prioritize BIOS boot partition in firmware detection

The first patch is merely a functional style refactoring. The 2nd patch introduces actual change in the logic. v1 + upstream discussion: https://listman.redhat.com/archives/libguestfs/2022-December/030401.html Andrey Drobyshev (2): inspect: use List.fold_left to iterate over partitions inspe

Re: [Libguestfs] [PATCH] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

On 12/21/22 10:53, Laszlo Ersek wrote: > On 12/20/22 21:57, Andrey Drobyshev wrote: >> On 12/20/22 11:51, Laszlo Ersek wrote: >>> On 12/19/22 23:16, Andrey Drobyshev wrote: >>> Now I'm a bit confused myself as a result of our discussion: should we really give priority to BIOS Boot partiti

Re: [Libguestfs] [V2V PATCH v2 1/2] inspect: use List.fold_left to iterate over partitions

On 12/21/22 17:38, Andrey Drobyshev wrote: > This patch is merely a refactoring and does not introduce any changes in > behaviour. It's used as a prelude for the next patch which prioritizes > BIOS boot partition when searching for the right firmware. > > Co-authored-by: Laszlo Ersek > Signed-of

Re: [Libguestfs] [V2V PATCH v2 2/2] inspect: check presence of BIOS boot partition to handle BIOS+GPT setup

On 12/21/22 17:38, Andrey Drobyshev wrote: > If the guest uses BIOS firmware but GPT partitioned disk, v2v inspection > might fail to correctly detect the firmware being used by the source mathine. > Namely, consider the following GPT partition table: > > Number Start (sector)End (sector) Si

Re: [Libguestfs] [v2v PATCH] windows_virtio: favor "fwcfg" over "qemufwcfg"

On 12/15/22 12:15, Laszlo Ersek wrote: > Virtio-win may provide the "qemufwcfg" stub driver and/or the "fwcfg" > actual driver. If both are provided, we must not install both, as they > conflict with each other. Pick "fwcfg" in this case. > > Because the drivers can originate from two sources (li