Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Richard W.M. Jones
On Tue, Aug 15, 2023 at 12:19:15PM +, Tage Johansson wrote: > I guess that we still use nbdkit with a unix socket when testing the > examples in run-tests.sh, right? Yes. In fact, we must since there may be other tests running in parallel, or simply an NBD server already sitting on a port. P

Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Tage Johansson
On 8/15/2023 11:00 AM, Richard W.M. Jones wrote: On Thu, Aug 10, 2023 at 11:24:36AM +, Tage Johansson wrote: This patch adds an example using the asynchronous Rust bindings. --- rust/Cargo.toml| 1 + rust/examples/concurrent-read-write.rs | 135

Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Richard W.M. Jones
On Tue, Aug 15, 2023 at 11:25:56AM +, Tage Johansson wrote: > > On 8/15/2023 11:07 AM, Richard W.M. Jones wrote: > >So what do I think about the patch series as a whole ... (in > >particular, the patches I didn't add Reviewed-by tags to). > > > >It would be much nicer IMHO if we didn't have t

Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Tage Johansson
On 8/15/2023 11:07 AM, Richard W.M. Jones wrote: So what do I think about the patch series as a whole ... (in particular, the patches I didn't add Reviewed-by tags to). It would be much nicer IMHO if we didn't have to define callback lifetimes in this way, since they were not intended to be cl

Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Richard W.M. Jones
So what do I think about the patch series as a whole ... (in particular, the patches I didn't add Reviewed-by tags to). It would be much nicer IMHO if we didn't have to define callback lifetimes in this way, since they were not intended to be classified into async_kind / cblifetime / cbcount, and

Re: [Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-15 Thread Richard W.M. Jones
On Thu, Aug 10, 2023 at 11:24:36AM +, Tage Johansson wrote: > This patch adds an example using the asynchronous Rust bindings. > --- > rust/Cargo.toml| 1 + > rust/examples/concurrent-read-write.rs | 135 + > rust/run-tests.sh.in

[Libguestfs] [libnbd PATCH v7 9/9] rust: async: Add an example

2023-08-10 Thread Tage Johansson
This patch adds an example using the asynchronous Rust bindings. --- rust/Cargo.toml| 1 + rust/examples/concurrent-read-write.rs | 135 + rust/run-tests.sh.in | 2 + 3 files changed, 138 insertions(+) create mode 100644 rust/e