Re: [Libguestfs] [libnbd PATCH] internal: Tweak use of attribute packed in union sbuf

2023-05-31 Thread Laszlo Ersek
On 5/31/23 17:48, Eric Blake wrote: > On Wed, May 31, 2023 at 12:45:16PM +0200, Laszlo Ersek wrote: >> On 5/31/23 04:10, Eric Blake wrote: >>> While analyzing 'union sbuf' in preparation to add more members to the >>> union, I noticed several things related to __attribute__((packed)) >>> that can b

Re: [Libguestfs] [libnbd PATCH] internal: Tweak use of attribute packed in union sbuf

2023-05-31 Thread Eric Blake
On Wed, May 31, 2023 at 12:45:16PM +0200, Laszlo Ersek wrote: > On 5/31/23 04:10, Eric Blake wrote: > > While analyzing 'union sbuf' in preparation to add more members to the > > union, I noticed several things related to __attribute__((packed)) > > that can be improved. It helps to note that that

Re: [Libguestfs] [libnbd PATCH] internal: Tweak use of attribute packed in union sbuf

2023-05-31 Thread Laszlo Ersek
On 5/31/23 04:10, Eric Blake wrote: > While analyzing 'union sbuf' in preparation to add more members to the > union, I noticed several things related to __attribute__((packed)) > that can be improved. It helps to note that that the bulk of the > members of 'union sbuf' are already marked packed s

Re: [Libguestfs] [libnbd PATCH] internal: Tweak use of attribute packed in union sbuf

2023-05-31 Thread Richard W.M. Jones
On Tue, May 30, 2023 at 09:10:13PM -0500, Eric Blake wrote: > While analyzing 'union sbuf' in preparation to add more members to the > union, I noticed several things related to __attribute__((packed)) > that can be improved. It helps to note that that the bulk of the > members of 'union sbuf' are

[Libguestfs] [libnbd PATCH] internal: Tweak use of attribute packed in union sbuf

2023-05-30 Thread Eric Blake
While analyzing 'union sbuf' in preparation to add more members to the union, I noticed several things related to __attribute__((packed)) that can be improved. It helps to note that that the bulk of the members of 'union sbuf' are already marked packed structures from nbd-protocol.h, where we don'