Re: [Libguestfs] [PATCH nbdkit 0/6] curl: Use a curl handle pool

2023-02-06 Thread Laszlo Ersek
On 2/4/23 13:34, Richard W.M. Jones wrote: > This experimental series changes the way that the curl plugin deals > with libcurl handles. It also changes the thread model of the plugin > from SERIALIZE_REQUESTS to PARALLEL. > > Currently one NBD connection opens one libcurl handle. This also > im

Re: [Libguestfs] [PATCH nbdkit 0/6] curl: Use a curl handle pool

2023-02-05 Thread Richard W.M. Jones
On Sun, Feb 05, 2023 at 05:09:21PM +, Richard W.M. Jones wrote: > On Sun, Feb 05, 2023 at 04:35:41PM +, Richard W.M. Jones wrote: > > I'm still adding instrumentation to see if the theory above is right, > > plus I have no idea how to fix this. > > Turns out I didn't need to add instrument

Re: [Libguestfs] [PATCH nbdkit 0/6] curl: Use a curl handle pool

2023-02-05 Thread Richard W.M. Jones
On Sun, Feb 05, 2023 at 04:35:41PM +, Richard W.M. Jones wrote: > I'm still adding instrumentation to see if the theory above is right, > plus I have no idea how to fix this. Turns out I didn't need to add instrumentation. Simply forcing nbdcopy to use at most 1 request per connection (-R 1)

Re: [Libguestfs] [PATCH nbdkit 0/6] curl: Use a curl handle pool

2023-02-05 Thread Richard W.M. Jones
On Sat, Feb 04, 2023 at 12:34:52PM +, Richard W.M. Jones wrote: > Anyway, this all seems to work, but it actually reduces performance :-( > > In particular this simple test slows down quite substantially: > > time ./nbdkit -r -U - curl file:/var/tmp/fedora-36.img --run 'nbdcopy > --no-exte

[Libguestfs] [PATCH nbdkit 0/6] curl: Use a curl handle pool

2023-02-04 Thread Richard W.M. Jones
This experimental series changes the way that the curl plugin deals with libcurl handles. It also changes the thread model of the plugin from SERIALIZE_REQUESTS to PARALLEL. Currently one NBD connection opens one libcurl handle. This also implies one TCP connection to the web server. If you wan