Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Eric Blake
On 10/05/2012 05:53 AM, Richard W.M. Jones wrote: > > And looking even more closely, I see disk->transient (not > implemented in the qemu driver ... why?) Lack of developer time :) [My usual excuse?] -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://lib

Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Eric Blake
On 10/05/2012 06:29 AM, Eric Blake wrote: > On 10/05/2012 05:53 AM, Richard W.M. Jones wrote: >> >> And looking even more closely, I see disk->transient (not >> implemented in the qemu driver ... why?) > > Lack of developer time :) [My usual excuse?] By the way, this is: https://bugzilla.redhat

Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Eric Blake
On 10/05/2012 05:40 AM, Richard W.M. Jones wrote: > > I notice that the qemu driver doesn't support snapshot drives > (-drive file=foo,snapshot=on). This is important for libguestfs. > > Currently libguestfs hacks this using . That works fine for > static disks in the libvirt XML, but lack of d

Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Richard W.M. Jones
On Fri, Oct 05, 2012 at 06:28:32AM -0600, Eric Blake wrote: > On 10/05/2012 05:40 AM, Richard W.M. Jones wrote: > > A simple implementation therefore would be to add a > > element to . It would just add snapshot=on and ignore concerns > > about $TMPDIR. > > > > Or reuse the flag? Note that the

Re: [Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

2012-10-05 Thread Richard W.M. Jones
On Fri, Oct 05, 2012 at 02:03:44PM +0200, Olaf Hering wrote: > On Fri, Oct 05, Richard W.M. Jones wrote: > > > On Fri, Oct 05, 2012 at 12:32:58PM +0200, Olaf Hering wrote: > > > No support for digits etc.? > > The underlying serial field supports digits and more (in fact it's > > really an arbitra

Re: [Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

2012-10-05 Thread Olaf Hering
On Fri, Oct 05, Richard W.M. Jones wrote: > On Fri, Oct 05, 2012 at 12:32:58PM +0200, Olaf Hering wrote: > > No support for digits etc.? > The underlying serial field supports digits and more (in fact it's > really an arbitrary 20 byte buffer). However I excluded digits in > this case because the

Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Richard W.M. Jones
And looking even more closely, I see disk->transient (not implemented in the qemu driver ... why?) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk

Re: [Libguestfs] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Richard W.M. Jones
On Fri, Oct 05, 2012 at 01:52:46PM +0200, Paolo Bonzini wrote: > Il 05/10/2012 13:40, Richard W.M. Jones ha scritto: > > I'm also concerned about the time is takes to run the external > > 'qemu-img create' command, which is non-trivial in some versions > > of qemu. In libguestfs, every millisecond

Re: [Libguestfs] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 13:40, Richard W.M. Jones ha scritto: > I'm also concerned about the time is takes to run the external > 'qemu-img create' command, which is non-trivial in some versions > of qemu. In libguestfs, every millisecond counts. qemu-img create is a thin wrapper for bdrv_create that would

Re: [Libguestfs] [libvirt] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Richard W.M. Jones
Reading back over the archives, I see there was a proposal to add a attribute. I don't think that was ever adopted. http://www.redhat.com/archives/libvir-list/2011-July/msg00649.html Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts phys

[Libguestfs] Support for qemu snapshot=on drives in libvirt

2012-10-05 Thread Richard W.M. Jones
I notice that the qemu driver doesn't support snapshot drives (-drive file=foo,snapshot=on). This is important for libguestfs. Currently libguestfs hacks this using . That works fine for static disks in the libvirt XML, but lack of direct support in libvirt is a blocker for adding hotplugging t

Re: [Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

2012-10-05 Thread Richard W.M. Jones
On Fri, Oct 05, 2012 at 12:32:58PM +0200, Olaf Hering wrote: > On Fri, Oct 05, Richard W.M. Jones wrote: > > > > > +=item C > + > +Give the disk a label. The label should be a unique, short > +string using I ASCII characters C<[a-zA-Z]>. > > No support for digits etc.? The underlying

Re: [Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

2012-10-05 Thread Olaf Hering
On Fri, Oct 05, Richard W.M. Jones wrote: > +=item C + +Give the disk a label. The label should be a unique, short +string using I ASCII characters C<[a-zA-Z]>. No support for digits etc.? Olaf ___ Libguestfs mailing list Libguestfs@redhat

[Libguestfs] [PATCH 2/2] launch: Add add_drive 'label' option.

2012-10-05 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/ From fb1c9667d500b6124d811b3e9166ec3bbb04cdaf

[Libguestfs] [PATCH 1/2] build: Use 'tmp-d' as name of temporary directory

2012-10-05 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org >From 6614d4f1d66921bf002067539b42c126d4bbfdb7 Mon Sep 17 00:00:00 2001 From: "Richard W.M. J

[Libguestfs] [PATCH 0/2] launch: Add add_drive 'label' option

2012-10-05 Thread Richard W.M. Jones
This completes the implementation previously posted here: https://www.redhat.com/archives/libguestfs/2012-October/msg2.html Instead of using 'serial', the option is now called 'label' and these are collectively called disk labels. Also the updated patch adds a test. Rich. -- Richard Jone