Re: [Libcdio-devel] [PATCH 1/4] Add case insensitive _cdio_stricmp and _cdio_strnicmp function calls

2024-01-29 Thread Pete Batard
Hi Rocky, On 2024.01.28 23:37, Rocky Bernstein wrote: With respect to this patch, the only nitpick I have is that we should add a comment for the new functions, even if it is something as basic as "case insensitive version of _cdio_strcmp / _cdio_strncmp" respectively. I don't mind adding that a

[Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-29 Thread Pete Batard
Changes from v1: * Fix duplicated comment in iso9660.h * Add comment in util.h for the stri... functions * Enable processing of images that follow the unofficial UEFI El-Torito specs extensions, to allow for images that are larger than 32 MB. On that later point: * Because it drastically reduces

[Libcdio-devel] [PATCH v2 1/4] Add case insensitive _cdio_stricmp and _cdio_strnicmp function calls

2024-01-29 Thread Pete Batard
--- include/cdio/util.h| 7 +++ lib/driver/libcdio.sym | 2 ++ lib/driver/util.c | 29 + 3 files changed, 38 insertions(+) diff --git a/include/cdio/util.h b/include/cdio/util.h index 9cca8f9f..e19fd4ac 100644 --- a/include/cdio/util.h +++ b/include/cdio

[Libcdio-devel] [PATCH v2 2/4] Add El Torito virtual boot image support

2024-01-29 Thread Pete Batard
Enables the El Torito boot images to be listed and extracted from a virtual "[BOOT]/" root directory. Limited to 8 maximum images and only for No Emulation. El Torito support can be enabled or disabled through ISO_EXTENSION_EL_TORITO. The naming convention of the virtual images follows what 7-zip

[Libcdio-devel] [PATCH v2 4/4] Add El Torito tests

2024-01-29 Thread Pete Batard
--- test/Makefile.am| 10 +++ test/check_eltorito.sh | 57 test/data/eltorito.iso | Bin 0 -> 55296 bytes test/data/eltorito_file | Bin 0 -> 512 bytes test/eltorito.right | 12 + test/no_eltorito.right | 8 ++ 6 files ch

[Libcdio-devel] [PATCH v2 3/4] Add --no-el-torito option to iso-info

2024-01-29 Thread Pete Batard
--- src/iso-info.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/iso-info.c b/src/iso-info.c index cfca76f7..8cba3111 100644 --- a/src/iso-info.c +++ b/src/iso-info.c @@ -87,6 +87,7 @@ static struct arguments intno_joliet; int

Re: [Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-29 Thread Pete Batard
I'll just add that I didn't formally test this, since I haven't had a chance to locate an ISO with a > 32MB El-Torito image yet. I did however validate, with the test El-Torito image, that if you remove the "(max_lsn - p_iso->boot_img[k].lsn) >= 0x4000" condition, you got the warning in iso-in

Re: [Libcdio-devel] [PATCH 1/4] Add case insensitive _cdio_stricmp and _cdio_strnicmp function calls

2024-01-29 Thread Thomas Schmitt via Libcdio-devel
Hi, Rocky Bernstein wrote: > Overall, I'd like to get those patches without any controversy into the > code soon. I am not 100% certain which ones have disputes in them. Is it > just Patch 2? Summary of everything that comes to my mind with v1. I read over v2 and find not much changes in regard t

Re: [Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-29 Thread Thomas Schmitt via Libcdio-devel
Hi, Pete Batard wrote: > I'll just add that I didn't formally test this, since I haven't had a chance > to locate an ISO with a > 32MB El-Torito image yet. You can build yourself one: - Get legacy PC-BIOS boot image isolinux.bin from e.g. a Debian netinst ISO: xorriso -osirrox on -indev d

Re: [Libcdio-devel] [PATCH 1/4] Add case insensitive _cdio_stricmp and _cdio_strnicmp function calls

2024-01-29 Thread Pete Batard
Hi Thomas, On 2024.01.29 14:35, Thomas Schmitt via Libcdio-devel wrote: - About all legacy PC-BIOS boot images of Linux installation ISOs will be shown with the recorded load size of 2048 bytes, although the file size of these images (x86 programs) is in the range of several dozen KiB.

Re: [Libcdio-devel] [PATCH v2 0/4] Add El Torito virtual image support

2024-01-29 Thread Pete Batard
Hi all, So... we have a problem: On 2024.01.29 15:04, Thomas Schmitt via Libcdio-devel wrote: Pete Batard wrote: I'll just add that I didn't formally test this, since I haven't had a chance to locate an ISO with a > 32MB El-Torito image yet. You can build yourself one: - Get legacy PC-BIOS