Re: [Libcdio-devel] [PATCH v3 0/2] Add Rock Ridge CE record processing

2023-03-23 Thread Thomas Schmitt
Hi, i think that the chnages are ripe for being accepted and thus pushed branch "pete_batard_ce_v3". Rocky, please merge. - Tests made: "git am" applied the v3 patches without complaints. Both known problems of v2 are gone:

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Thomas Schmitt
Hi, the patch applies and compiles without complaints. I was riddling about the exact meaning of "{ 0 }" when the struct has more than one member. In Linux time.h struct tm is declared with 11 members. Finally i found in C11 specs (ISO/IEC 9899:2011 6.7.9 21): If there are fewer initializers in

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Rocky Bernstein
On Thu, Mar 23, 2023 at 3:12 PM Thomas Schmitt wrote: > Hi, > > the patch applies and compiles without complaints. > > I was riddling about the exact meaning of "{ 0 }" when the struct has more > than one member. In Linux time.h struct tm is declared with 11 members. > Finally i found in C11 spec

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Pete Batard via Libcdio-devel
Actually I don't mind if you guys sort it out as last time I checked (a couple years ago), I had lost my ssh access right (which means that right now I'm just using https to clone the repo) and I'm a bit busy with other stuff ATM. I'm actually quite happy to see that Thomas has take upon himse

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Rocky Bernstein
Ok. Just give me the SHA1 of the code that you'd like to see in master and I will test it as well. And assuming everything works and it looks like what has been mentioned here, I will merge it and let everyone know. On Thu, Mar 23, 2023 at 3:58 PM Pete Batard wrote: > Actually I don't mind if yo

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Pete Batard via Libcdio-devel
I guess that would be fdd76a8ee4f4f00f1eabc6f632322db800ee9970 from the pete_batard_ce_v3 branch. And then there's the one patch from pete_batard_ce_v3 with SHA 569c452f8d1650c0ec50ebeef7869b54ed9c8be6. Thanks! /Pete On 2023.03.23 20:03, Rocky Bernstein wrote: Ok. Just give me the SHA1 of the

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Rocky Bernstein
And for clarity use git show to get the SHA1. I just pulled master and here is what I currently see: $ git show commit 6f2426e8bf4dc5269ccbd9fbfa94340895f8be6e (HEAD -> master, origin/master, origin/HEAD) Author: Robert Kausch Date: Wed Mar 15 00:02:10 2023 +0100 Fix crash reading CD TOC o

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Rocky Bernstein
Ok got it - thanks! I will have to do this a bit later though because I want to be careful and test everything and I cannot do that right now. On Thu, Mar 23, 2023 at 4:10 PM Pete Batard wrote: > I guess that would be fdd76a8ee4f4f00f1eabc6f632322db800ee9970 from the > pete_batard_ce_v3 branch.

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Thomas Schmitt
Hi, Rocky Bernstein wrote: > I was thinking that Pete would do the merge since he also has commit rights > after the two of you decide that it is time to merge Everybody is more qualified as git admin than i am. Pete Batard wrote: > Actually I don't mind if you guys sort it out as last time I

Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-23 Thread Rocky Bernstein
On Thu, Mar 23, 2023 at 5:13 PM Thomas Schmitt wrote: > Hi, > > Rocky Bernstein wrote: > > I was thinking that Pete would do the merge since he also has commit > rights > > after the two of you decide that it is time to merge > > Everybody is more qualified as git admin than i am. > > > Pete Bat

[Libcdio-devel] CD-Text support for macOS and Windows

2023-03-23 Thread Robert Kausch via Libcdio-devel
Hi all, It's been a long time since I've been active here and it's time to contribute some patches again... I just pushed the cdtext-osx and cdtext-win32 branches which add/improve support for reading CD-Text on those systems. The win32 branch also has patches for the Windows-specific text c