Re: [Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-22 Thread Rocky Bernstein
I hope this is obvious but I'll say it anyway. I do not have any comment on the patches, and you should feel free to merge whenever you and Thomas are mutually satisfied. When the dust settles, if you all think we need to do a release I can do that. On Wed, Mar 22, 2023 at 5:10 PM Pete Batard wr

[Libcdio-devel] [PATCH] Fix gcc warnings

2023-03-22 Thread Pete Batard
gcc 12.2.0 on MinGW produces multiple warnings similar to the one below: In function 'iso9660_set_dtime', inlined from 'iso9660_dir_add_entry_su' at iso9660.c:782:3: iso9660.c:353:44: warning: 'temp_tm.tm_isdst' may be used uninitialized [-Wmaybe-uninitialized] 353 | time_zone =

[Libcdio-devel] [PATCH v3 0/2] Add Rock Ridge CE record processing

2023-03-22 Thread Pete Batard
Changes from v2: * Remove semicolon in macro to prevent a compilation warning * Use a single buffer * Switch to using iso733_t in iso_su_ce_s Pete Batard (2): Clean up rock.h and fix the use of char arrays in iso_su_ce_s Add processing of Rock Ridge CE records include/cdio/rock.h | 20 --

[Libcdio-devel] [PATCH v3 2/2] Add processing of Rock Ridge CE records

2023-03-22 Thread Pete Batard
Use the processed cont_extent to read the relevant continuation block once the current extensions have been processed. The code is designed to handle chained CE blocks if needed, and we also add code to detect ISOs that are abusing the specs to loop CEs. Also clean up the CHECK...() macros and fix

[Libcdio-devel] [PATCH v3 1/2] Clean up rock.h and fix the use of char arrays in iso_su_ce_s

2023-03-22 Thread Pete Batard
Using char arrays for extent, offset and size results in from_733() issues when processing CE data. Also harmonize to always use stdint types where possible. --- include/cdio/rock.h | 20 ++-- lib/iso9660/rock.c | 6 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff