Re: zlib patch

2006-01-11 Thread Archaic
On Wed, Jan 11, 2006 at 02:29:41PM -0600, Tushar Teredesai wrote: > > There already is:) Check out the bzip2 patch to install additional > documentation. You got a point there. It would probably be better to just manually cp the doco instead of hacking the Makefile. -- Archaic Want control, ed

Re: zlib patch

2006-01-11 Thread Tushar Teredesai
On 1/9/06, Dan Nicholson <[EMAIL PROTECTED]> wrote: > On 1/9/06, Tushar Teredesai <[EMAIL PROTECTED]> wrote: > > > > Building seperate shared and static object files is how most of the > > builds are performed. Forgetting to perform a make clean after > > builiding the shared lib can cause unwanted

Re: zlib patch

2006-01-09 Thread Bruce Dubbs
Dan Nicholson wrote: > On 1/9/06, Tushar Teredesai <[EMAIL PROTECTED]> wrote: > >>Building seperate shared and static object files is how most of the >>builds are performed. Forgetting to perform a make clean after >>builiding the shared lib can cause unwanted results. Gentoo's patch >>just brings

Re: zlib patch

2006-01-09 Thread Bruce Dubbs
Dan Nicholson wrote: > So, I guess you could put the colon in. It should work the same > except in the situation where CFLAGS is null: > > $ export CFLAGS="" > $ echo ${CFLAGS:--O3} > -O3 > $ echo ${CFLAGS--O3} > > What do you think is more proper? I'd say that the use of the colon is better.

Re: zlib patch

2006-01-09 Thread Dan Nicholson
On 1/9/06, Tushar Teredesai <[EMAIL PROTECTED]> wrote: > > Building seperate shared and static object files is how most of the > builds are performed. Forgetting to perform a make clean after > builiding the shared lib can cause unwanted results. Gentoo's patch > just brings zlib into compliance wi

Re: zlib patch

2006-01-09 Thread Dan Nicholson
On 1/9/06, Bruce Dubbs <[EMAIL PROTECTED]> wrote: > SFLAGS="${CFLAGS:--O3} -fPIC" > > Note the colon and missing internal double quotes. The colon is a bashism. On /bin/sh, the colon doesn't work. Wait, I thought the colon was a bashism, but on the RHEL3 system at work, it works with ash, zsh an

Re: zlib patch

2006-01-09 Thread Tushar Teredesai
On 1/9/06, Dan Nicholson <[EMAIL PROTECTED]> wrote: > > Tushar, I like what's in the patch, but I'm not a big fan of adding a > patch to drastically alter the build system. Building seperate shared and static object files is how most of the builds are performed. Forgetting to perform a make clean

Re: zlib patch

2006-01-09 Thread Bruce Dubbs
Dan Nicholson wrote: > sed -i 's/SFLAGS=.*/SFLAGS="${CFLAGS-"-O3"} -fPIC"/' configure This confuses me. Do you mean: SFLAGS="${CFLAGS:--O3} -fPIC" Note the colon and missing internal double quotes. -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromsc

Re: zlib patch

2006-01-09 Thread Dan Nicholson
On 1/3/06, Tushar Teredesai <[EMAIL PROTECTED]> wrote: > Sometime back I added a patch to the patches repository that adds > -fPIC to the compiler flags when compiling shared library. > Additionally it allows building the shared and static library in a > single pass. See: >

zlib patch

2006-01-03 Thread Tushar Teredesai
Sometime back I added a patch to the patches repository that adds -fPIC to the compiler flags when compiling shared library. Additionally it allows building the shared and static library in a single pass. See: . Though