Re: [PATCH] pidofproc broken when passing a pid file

2007-03-13 Thread Dan Nicholson
On 3/13/07, Dan Nicholson <[EMAIL PROTECTED]> wrote: > > I'm gonna go ahead and commit this. Applied in r7962. -- Dan -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page

Re: [PATCH] pidofproc broken when passing a pid file

2007-03-13 Thread Dan Nicholson
On 3/13/07, Matthew Burgess <[EMAIL PROTECTED]> wrote: > On Monday 12 March 2007 19:56, Dan Nicholson wrote: > > The bootscript function pidofproc is broken when passing a specific > > pidfile with -p. The problem is that there's an integer expression > > using -ge, but the tested argument may be n

Re: [PATCH] pidofproc broken when passing a pid file

2007-03-13 Thread Matthew Burgess
On Monday 12 March 2007 19:56, Dan Nicholson wrote: > The bootscript function pidofproc is broken when passing a specific > pidfile with -p. The problem is that there's an integer expression > using -ge, but the tested argument may be null. The patch looks sane to me, Dan. Of course, it loses the

[PATCH] pidofproc broken when passing a pid file

2007-03-12 Thread Dan Nicholson
The bootscript function pidofproc is broken when passing a specific pidfile with -p. The problem is that there's an integer expression using -ge, but the tested argument may be null. Here's the boiled down test case: # /bin/sh -c ". /etc/rc.d/init.d/functions && pidofproc -p /var/run/syslogd.pid