On 03/29/2017 08:57 PM, Jo-Philipp Wich wrote:
> Hi Pau,
>
> I will not reiterate the arguments made elsewhere in this thread but
> merely describe why the version tagged 17.01.0 SDK uses fixed feed sources.
>
> The main objective here was to make the build reproducible in a way that
> you can us
On 04/06/2017 05:45 AM, Joe Ayers wrote:
> Matthias, was there ever a conclusion to this post:
> http://lists.infradead.org/pipermail/linux-mtd/2016-March/066348.html
> ?
>
> My interest from http://www.aredn.org is support for Ubiquiti
> PBE-M5-620 and I suspect this issue is related.
>
> [ 0.5
Not all topology or connectivity changes may be detected by netifd,
depending on the underlying technology (e.g. VPN software); this adds a way
to explicitly trigger a renew.
Signed-off-by: Matthias Schiffer
---
interface.c | 9 +
interface.h | 1 +
ubus.c | 14 ++
3
This allows us to make use of upgraded in "snapshot convert" as well.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...d-s
ncluded in the LEDE repo for now
to facilitate testing the series.
Matthias
Matthias Schiffer (13):
procd: prepare NAND sysupgrade for making upgraded dynamically linked
procd: system: always support staged sysupgrade
procd: upgraded: link dynamically, chroot during exec
procd: upgraded: a
method that will become unused with the staged sysupgrade is
retained for now.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...1-system-alwa
Use install_bin to copy upgraded with all dependencies. The old name
/tmp/upgraded is temporarily retained as a symlink to avoid breaking
things.
Signed-off-by: Matthias Schiffer
---
package/system/procd/files/nand.sh | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a
ation, and libraries need to be made
available.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...raded-link-dynamically-chroot-during-exec.p
All targets with NAND support should gradually move their nand_do_upgrade
calls from platform_pre_upgrade to platform_do_upgrade.
Signed-off-by: Matthias Schiffer
---
target/linux/ramips/base-files/lib/upgrade/platform.sh | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git
We can reuse the kill_remaining and run_ramfs facilities of the stage2 run
by upgraded.
Signed-off-by: Matthias Schiffer
---
package/system/fstools/Makefile | 2 +-
package/system/fstools/files/snapshot | 16 +---
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git
Signed-off-by: Matthias Schiffer
---
.../base-files/files/lib/preinit/40_run_failsafe_hook | 6 +-
.../base-files/files/lib/preinit/99_10_failsafe_login | 11 +++
package/base-files/files/sbin/sysupgrade | 18 +-
3 files changed, 25 insertions(+), 10
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...-that-has-become-unnecessary-after-sysupg.patch | 120 +
1 file
This will allow to add sysupgrade support via upgraded for failsafe mode.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...pport-for
We always want to support staged upgrades now, so it's better to include
upgraded into the main package. /lib/upgrade/nand.sh is moved to
base-files.
The procd-nand-firstboot package is removed for now, it may return later
as a separate package.
Signed-off-by: Matthias Schiffer
---
pa
e ask_bool that can't work anymore with
staged sysupgrade.
Signed-off-by: Matthias Schiffer
---
target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/linux/x86/base-files/lib/upgrade/platform.sh
b/target/linux/x86/ba
allow unmounting the root filesystem.
Signed-off-by: Matthias Schiffer
---
package/base-files/files/lib/upgrade/common.sh | 123 +++--
package/base-files/files/lib/upgrade/nand.sh | 60 ++--
package/base-files/files/lib/upgrade/stage2| 50 ++
package
that function on some targets. Targets that do the latter should be
fixed eventually to use platform_do_upgrade for that purpose.
Signed-off-by: Matthias Schiffer
---
package/base-files/files/lib/upgrade/common.sh | 100 -
package/base-files/files/lib/upgrade/stage2
On 04/24/2017 12:19 PM, Jo-Philipp Wich wrote:
> Hi,
>
>> While we're at it, also remove the ask_bool that can't work anymore with
>> staged sysupgrade.
>
> We should find an alternative solution though; like some new flag
> "--proceed-even-if-partition-table-changed" to avoid accidentally
> kill
On 04/24/2017 10:05 PM, Philip Prindeville wrote:
> Inline…
>
>> On Apr 23, 2017, at 6:06 PM, Matthias Schiffer
>> wrote:
>>
>> Use install_bin to copy upgraded with all dependencies. The old name
>> /tmp/upgraded is temporarily retained as a symlink to av
On 05/11/2017 12:17 AM, Hauke Mehrtens wrote:
> Thanks for moving this forward.
>
> On 05/08/2017 03:19 PM, John Crispin wrote:
>> *) github
> .
>>
>> - obsolete the lede github org after a grace period of 3-6 months
>
> As long as it does not cost us effort I would like to keep the lede
> doma
[Some lists were dropped from this thread, adding again]
>
>>> According to the rules there shall be no personal mail accounts at all.
>>> There should be plenty of time until the actual remerge to fade them out
>>> and to set up forwarding elsewhere.
>>
>> I hope you agree that a merge means bo
method that will become unused with the staged sysupgrade is
retained for now.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...1-system-alwa
Signed-off-by: Matthias Schiffer
---
package/system/procd/files/nand.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/system/procd/files/nand.sh
b/package/system/procd/files/nand.sh
index 01dba61644..b5f86e0301 100644
--- a/package/system/procd/files/nand.sh
far.
Matthias
Matthias Schiffer (19):
procd: clean up trailing whitespace in nand.sh
procd: prepare NAND sysupgrade for making upgraded dynamically linked
procd: system: always support staged sysupgrade
procd: upgraded: link dynamically, chroot during exec
procd: upgraded: add support for pass
Use install_bin to copy upgraded with all dependencies. The old name
/tmp/upgraded is temporarily retained as a symlink to avoid breaking
things.
Signed-off-by: Matthias Schiffer
---
package/system/procd/files/nand.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a
ation, and libraries need to be made
available.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...raded-link-dynamically-chroot-during-exec.p
Signed-off-by: Matthias Schiffer
---
.../base-files/files/lib/preinit/40_run_failsafe_hook | 6 +-
.../base-files/files/lib/preinit/99_10_failsafe_login | 11 +++
package/base-files/files/sbin/sysupgrade | 18 +-
3 files changed, 25 insertions(+), 10
We can reuse the kill_remaining and run_ramfs facilities of the stage2 run
by upgraded.
Signed-off-by: Matthias Schiffer
---
package/system/fstools/Makefile | 2 +-
package/system/fstools/files/snapshot | 14 --
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a
Signed-off-by: Matthias Schiffer
---
package/system/fstools/files/snapshot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/system/fstools/files/snapshot
b/package/system/fstools/files/snapshot
index c1a5b733f3..baf24f1e3e 100644
--- a/package/system/fstools/files
All targets with NAND support should gradually move their nand_do_upgrade
calls from platform_pre_upgrade to platform_do_upgrade.
Signed-off-by: Matthias Schiffer
---
target/linux/ramips/base-files/lib/upgrade/platform.sh | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git
We always want to support staged upgrades now, so it's better to include
upgraded into the main package. /lib/upgrade/nand.sh is moved to
base-files.
The procd-nand-firstboot package is removed for now, it may return later
as a separate package.
Signed-off-by: Matthias Schiffer
---
pa
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...-that-has-become-unnecessary-after-sysupg.patch | 120 +
1 file
This allows us to make use of upgraded in "snapshot convert" as well.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...d-s
that function on some targets. Targets that do the latter should be
fixed eventually to use platform_do_upgrade for that purpose.
Signed-off-by: Matthias Schiffer
---
package/base-files/files/lib/upgrade/common.sh | 100 ---
package/base-files/files/lib/upgrade/stage2
This will allow to add sysupgrade support via upgraded for failsafe mode.
Signed-off-by: Matthias Schiffer
Note: obviously, this patch should go into the procd repo when it is
actually applied; it is provided like this for now to allow easier testing
of the whole series.
---
...pport-for
allow unmounting the root filesystem.
Signed-off-by: Matthias Schiffer
---
package/base-files/files/lib/upgrade/common.sh | 123 +++--
package/base-files/files/lib/upgrade/nand.sh | 60 ++--
package/base-files/files/lib/upgrade/stage2| 50 ++
package
1024KiB).
In addition, conv=notrunc is replaced with conv=fsync. It seems this was an
oversight, as notrunc doesn't make sense for block devices and all other dd
commands use conv=fsync.
Signed-off-by: Matthias Schiffer
---
target/linux/sunxi/base-files/lib/upgrade/platform.sh | 2 +-
1
This should ensure that the kernel partition can be mounted in
platform_copy_config when its size has changed.
Signed-off-by: Matthias Schiffer
---
target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/target/linux/x86/base-files/lib
: sysupgrade: explicitly rescan disk after writing partition table
Signed-off-by: Matthias Schiffer
---
target/linux/sunxi/Makefile| 2 +-
.../linux/sunxi/base-files/lib/upgrade/platform.sh | 120 -
2 files changed, 72 insertions(+), 50 deletions(-)
diff --git
By returning early when no upgrade device can be found and handling the
SAVE_PARTITIONS=0 case differently, we can get rid of two levels of if.
Signed-off-by: Matthias Schiffer
---
.../linux/x86/base-files/lib/upgrade/platform.sh | 69 +++---
1 file changed, 36 insertions
The staged sysupgrade will prevent us from using ask_bool in
platform_do_upgrade; therefore, the check is moved to platform_check_image.
Signed-off-by: Matthias Schiffer
---
.../linux/x86/base-files/lib/upgrade/platform.sh | 29 +++---
1 file changed, 25 insertions(+), 4
On 05/29/2017 09:03 AM, John Crispin wrote:
> (resend, this time as plain text)
>
> Hi,
>
> here is a V3 of the remerge proposal, I tried to fold all the comments
> people made into it, if anything is missing let me know. Please remeber
> that post remerge anything can be voted on, so cluttering
On 05/31/2017 11:02 PM, Florian Fainelli wrote:
> Add a CMake FIND_PATH and INCLUDE_DIRECTORIES searching for
> libubox/uloop.h. Some external toolchains which do not include standard
> locations would fail to find the header otherwise.
>
> Signed-off-by: Florian Fainelli
> ---
> upgraded/CMakeL
On 06/22/2017 10:50 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki
>
> The purpose of revision (r* number) is to provide a rough info about
> build next to the (very) specific SHA-1. Unfortunately without a branch
> name specified it's a bit misleading and what's more two commits may get
> the sa
On 07/02/2017 04:05 PM, Hauke Mehrtens wrote:
> Hi,
>
> I just tried to run sysupgrade on a WRT53GS (brcm47xx) device and it
> failed. I am running LEDE r4504.
>
> Hauke
Hmm, the "Could not get image magic" and "Image check failed." message are
from mtd itself. What exactly does mtd check here?
logic is that
build dependencies are now always interpreted as source package names,
instead of putting build and runtime dependencies into the same list.
Fixes FS#837.
Signed-off-by: Matthias Schiffer
---
Some thorough review would be appreciated, I forgot almost all I once knew
about Perl
logic is that
build dependencies are now always interpreted as source package names,
instead of putting build and runtime dependencies into the same list.
Fixes FS#837.
Signed-off-by: Matthias Schiffer
---
v2: Fixed an issue that caused syntax errors in .config-package.in for
dependencies on on
On 07/08/2017 09:18 PM, Matthias Schiffer wrote:
> Instead of adding virtual packages to the normal package list, keep a
> separate list for provides, make each package provide itself, and resolve
> all dependencies through this list. This allows to use PROVIDES to replace
> exist
On 06/22/2017 02:07 AM, Daniel Golle wrote:
> uhttpd refered to ustream-ssl as PKG_BUILD_DEPENDS. While this
> intuitively seems like the correct thing to do, it turns out not to
> have the desired effect: PKG_BUILD_DEPENDS needs to list the resulting
> package name (ie. one of libustream-*) and no
On 07/10/2017 01:02 AM, Piotr Dymacz wrote:
> We use combined option in "mktplinkfw" tool for generating initramfs
> kernel images and header for kernel inside "safeloader" image type (in
> fact, only for TL-WR1043ND v4 at this moment).
>
> There is also "mktplinkfw-kernel" tool, a stripped-down v
umed.
Signed-off-by: Matthias Schiffer
---
scripts/getver.sh | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/getver.sh b/scripts/getver.sh
index 215bb036a5..f6d18bb3a3 100755
--- a/scripts/getver.sh
+++ b/scripts/getver.sh
@@ -5,6 +5,10 @@ export LC_ALL=C
GET_
Correctly return "unknown" instead of printing various error messages,
followed by a "r0-..." revision.
Signed-off-by: Matthias Schiffer
---
scripts/getver.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/getver.sh b/scripts/getver.sh
index 9175f411db..103
Signed-off-by: Matthias Schiffer
---
scripts/getver.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/getver.sh b/scripts/getver.sh
index f6d18bb3a3..30cf32ed14 100755
--- a/scripts/getver.sh
+++ b/scripts/getver.sh
@@ -10,7 +10,7 @@ get_branch() {
}
try_version
We don't use Mercurial, try_hg didn't understand GET_REV, and its output
didn't have anything to do with the way LEDE counts revisions.
Signed-off-by: Matthias Schiffer
---
scripts/getver.sh | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/scripts/getv
On 07/10/2017 02:19 AM, Matthias Schiffer wrote:
> To determine the originating branch of a commit, a file called "branch"
> must be added to the root of the repository (similar to the existing
> "version" file used to override the getver.sh logic). When no such f
On 07/12/2017 08:02 PM, Philip Prindeville wrote:
>
>> On Jul 11, 2017, at 3:19 AM, Hans Dedecker wrote:
>>
>> Hi,
>>
>> I would like to cherry-pick the start/stop kernel watchdog support to
>> the lede-17.01 procd branch :
>>
>> e5e99c4 watchdog: add support for starting/stopping kernel watchdog
On 07/15/2017 09:44 PM, Florian Fainelli wrote:
> chroot() can fail and its return value should be checked against so propagate
> sysupgrade_exec_upgraded() return value to its caller.
>
> Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from
> preinit")
> Signed-off-by: Florian
t; [-Werror=unused-result] chroot(".");
>
> Fixes: 056d8ddda8d5 ("upgraded: link dynamically, chroot during exec")
> Signed-off-by: Florian Fainelli
> ---
LGTM.
Reviewed-by: Matthias Schiffer
> upgraded/upgraded.c | 5 -
> 1 file changed, 4 insertions(+),
On 07/18/2017 03:33 AM, Florian Fainelli wrote:
> chroot() can fail and its return value should be checked against, in that case
> do an exit() since this is a fatal condition that we cannot recover from.
>
> Fixes: 63789e51ed91 ("init: add support for sysupgrades triggered from
> preinit")
> Sig
d from
> preinit")
> Signed-off-by: Florian Fainelli
> ---
> sysupgrade.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Matthias Schiffer
You should be able to push this yourself, otherwise I can do it later today
(I'll also add another com
On 07/08/2017 09:18 PM, Matthias Schiffer wrote:
> Instead of adding virtual packages to the normal package list, keep a
> separate list for provides, make each package provide itself, and resolve
> all dependencies through this list. This allows to use PROVIDES to replace
> exist
On 08/07/2017 06:14 PM, Philip Prindeville wrote:
> I’m seeing the following when building bind:
>
> OpenWrt-libtool: link: x86_64-openwrt-linux-musl-gcc -Os -pipe
> -fno-caller-saves -fno-plt -fhonour-copts -Wno-error=unused-but-set-variable
> -Wno-error=unused-result
> -iremap/home/philipp/be
n the host,
as neither IPv4 addresses nor DNS names can contain colons. An alternative
would be to add a flag to the uclient_url struct; but as this struct is
exposed in public headers, such a change could be considered an ABI change,
making a backport difficult.
Signed-off-by: Matthias Schiffer
-
-SNIP-
>
>> * ubnt-uap-pro
>> * ubnt-unifi-outdoor-plus
>
> No idea about these two.
>
I have a UAP Outdoor+ here, I'll have a look at it soon-ish.
Matthias
signature.asc
Description: OpenPGP digital signature
___
Lede-dev mailing lis
On 10/29/2017 09:21 PM, Paul Spooren wrote:
> Hi all,
>
> I'm currently trying to use jshn.sh but it changes the data and makes it
> unusable.
>
> Below an example:
>
> root@LEDE:~# json_string="{ \"foo-bar\": 10 }"
> root@LEDE:~# echo $json_string
> { "foo-bar": 10 }
> root@LEDE:~# json_init
>
On 10/30/2017 09:58 PM, Paul Spooren wrote:
> On 10/30/17 3:28 AM, Matthias Schiffer wrote:
>> On 10/29/2017 09:21 PM, Paul Spooren wrote:
>>> Hi all,
>>>
>>> I'm currently trying to use jshn.sh but it changes the data and makes it
>>> unu
On 11/07/2017 07:23 AM, David Lang wrote:
> 17.01 is pointer to a particular commit on the master branch
>
> I haven't looked at the specific method used for the r# generation, but I
> think it's incremented daily
r# is the number of commits since the "reboot" tag. If your local branch
(e.g. "mas
On 11/07/2017 01:19 PM, Sven Eckelmann wrote:
> The beacon_int is currently set explicitly for hostapd and when LEDE uses
> iw to join an IBSS/mesh. But it was not done when wpa_supplicant was used
> to join an encrypted IBSS or mesh.
>
> This configuration is required when an AP interface is conf
On 11/07/2017 03:25 PM, James Feeney wrote:
> On 11/06/2017 11:44 PM, Matthias Schiffer wrote:
>> r# is the number of commits since the "reboot" tag. If your local branch
>> (e.g. "master") has a upstream branch (e.g. "origin/master"), it will use
>
On 11/07/2017 06:20 PM, Bjørn Mork wrote:
> Matthias Schiffer writes:
>
>> Fixing our revision numbering to include the branch name to make this more
>> or less unambiguous is the intent of the two patches I linked. The commit
>> ID should still be included in this revis
On 11/08/2017 10:57 AM, Zefir Kurtisi wrote:
> On 11/07/2017 09:24 PM, Rosen Penev wrote:
>> Less verbose
>>
>> Signed-off-by: Rosen Penev
>> ---
>> interface.c | 22 --
>> 1 file changed, 8 insertions(+), 14 deletions(-)
>>
>> diff --git a/interface.c b/interface.c
>> index 7
On 11/17/2017 10:14 AM, Jonas Gorski wrote:
> On 17 November 2017 at 01:41, wrote:
>> From: Luiz Angelo Daros de Luca
>>
>> Only backup /aaa/bbb/ccc if /rom/aaa/bbb/ccc does not exist
>> or /aaa/bbb/ccc is different from /rom/aaa/bbb/ccc.
>>
>> Signed-off-by: Luiz Angelo Daros de Luca
>> ---
>>
On 11/24/2017 08:11 AM, Luiz Angelo Daros de Luca wrote:
>>> After applied, the list of files in backup in a fresh installation change
>>> from:
>>> to:
>>>
>>> root at LEDE:~# sysupgrade -l
>>> /etc/config/dhcp
>>> /etc/config/firewall
>>> /etc/config/network
>>> /etc/config/system
>>> /etc/drop
On 11/28/2017 10:51 PM, Christian Lamparter wrote:
> Targets that either directly or indirectly set
> CONFIG_TARGET_IMAGES_GZIP currently have no way
> to append the metadata at the end of new image
> creation process. And this is going to be
> necessary in order to convert the targets to use
> the
On 12/06/2017 12:40 AM, Roman Yeryomin wrote:
> On 2017-12-05 21:52, Hans Dedecker wrote:
>> On Tue, Dec 5, 2017 at 5:22 PM, Roman Yeryomin wrote:
>>> It's better not to configure ifname separately since they
>>> are tied together.
>>>
>>> Signed-off-by: Roman Yeryomin
>>> ---
>>> package/base-f
Your build is based on an old .config that enables "odhcpd" (as it was the
default in the past). The latest master includes a package
"odhcpd-ipv6only", which is the default since
c7b052db739e50f8a40f95ac17a21363b1593e33.
Our Kconfig-based .config management can't properly deal with conficting
pac
ng is applied as
intended, and as it is done for the other packages. Do we have any numbers
how much hardening usually increases binary sizes?
Regrads,
Matthias
Matthias Schiffer (3):
include/package.mk: remove old configured stamps before attempting
configuration
busybox: streamline Mak
rules can be dropped.
Signed-off-by: Matthias Schiffer
---
include/package.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/package.mk b/include/package.mk
index 5dc4aec70d..c0dbf12787 100644
--- a/include/package.mk
+++ b/include/package.mk
@@ -165,11 +165,11
these flags increases the size of the stripped busybox
binary by about 6KB (~4KB with fortify headers, ~2KB with "-znow -zrelro")
with the default hardening options PKG_FORTIFY_SOURCE_1 and PKG_RELRO_FULL.
Signed-off-by: Matthias Schiffer
---
package/utils/busybox/Makefile | 5 +++
Use default Build/Install steps where possible. No binary change in default
configuration, so PKG_RELEASE is not incremented.
Signed-off-by: Matthias Schiffer
---
package/utils/busybox/Makefile | 67 +++---
1 file changed, 17 insertions(+), 50 deletions
On 12/12/2017 11:24 AM, John Crispin wrote:
>
>
> board_config_flush() {
> + # when calling json_dump with a redirect, the shell will truncate the
> target
> + # file and not update it until a close/flush is called. this results in
> a short
> + # window where the file is 0 bytes.
Unless you have the option odhcpd_is_main in /etc/config/dhcp, odhcpd has
never been used for IPv4, but only for DHCPv6; IPv4 DHCP is handled by
dnsmasq by default. The switch to odhcpd-ipv6only simply removes some
unused clutter from our default package set.
Regards,
Matthias
On 12/12/2017 11:1
On 12/12/2017 11:01 PM, Jonas Gorski wrote:
> On 12 December 2017 at 21:03, Jo-Philipp Wich wrote:
>> Hi Piotr,
>>
>> my rough idea was to somehow tie the manifest generation to the "define
>> Device/*" macros present in the image building code because there you
>> have all required information in
Signed-off-by: Matthias Schiffer
---
scripts/metadata.pm | 3 ---
scripts/package-metadata.pl | 8
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/scripts/metadata.pm b/scripts/metadata.pm
index e636a45a33..50f91407d6 100644
--- a/scripts/metadata.pm
+++ b/scripts
Every single reference to subdir was concatenated with the source package
name, so it makes sense to store the concatenated value instead.
Signed-off-by: Matthias Schiffer
---
scripts/metadata.pm | 12 +++-
scripts/package-metadata.pl | 25 -
2 files
Build types are a property of source rather than binary packages. This is a
preparation for followup cleanup.
Signed-off-by: Matthias Schiffer
---
scripts/metadata.pm | 4 ++--
scripts/package-metadata.pl | 13 +++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git
We often want to access fields of a source packages through pkg->{src}.
Allow accessing them directly instead of resolving the source hash through
srcpackages.
Signed-off-by: Matthias Schiffer
---
scripts/feeds | 4 ++--
scripts/metadata.pm |
lexicographically
first).
Signed-off-by: Matthias Schiffer
---
scripts/metadata.pm | 1 +
scripts/package-metadata.pl | 61 ++---
2 files changed, 36 insertions(+), 26 deletions(-)
diff --git a/scripts/metadata.pm b/scripts/metadata.pm
index c150b547f1
Nothing explicitly depends on base-files, and even if it would, it would
not cause any problems. Remove the unused special case.
Signed-off-by: Matthias Schiffer
---
scripts/package-metadata.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package-metadata.pl b
Eventually the BUILDONLY package flag could be replaced by simply creating
a package Makefile without any BuildPackage calls. This will fail for now,
as BuildPackage also causes the Makefile's compile target etc. to do
something useful at all.
Signed-off-by: Matthias Schiffer
---
in
ors)?
As hinted in patch 15, I have further refactoring in mind, but let's try to
get this set reviewed and committed first...
Regards,
Matthias
[1] https://github.com/openwrt/packages/pull/5370
[2] https://github.com/openwrt-routing/packages/pull/345
Matthias Schiffer (15):
metadat
Turn the srcpackage values into hashes to allow storing more information
than just binary package names.
Signed-off-by: Matthias Schiffer
---
scripts/feeds | 2 +-
scripts/metadata.pm | 6 --
scripts/package-metadata.pl | 2 +-
3 files changed, 6 insertions(+), 4
Build depends must refer to source packages rather than binary package
names.
Signed-off-by: Matthias Schiffer
---
include/autotools.mk | 4 ++--
include/nls.mk | 2 +-
package/network/config/ltq-adsl-app/Makefile | 2 +-
package/network
packages.
Signed-off-by: Matthias Schiffer
---
scripts/package-metadata.pl | 112
1 file changed, 41 insertions(+), 71 deletions(-)
diff --git a/scripts/package-metadata.pl b/scripts/package-metadata.pl
index e492cc8a09..980ad24dc0 100755
--- a/scripts
to binary packages afterwards.
This does lead to PKG_BUILD_DEPENDS entries referring to binary package
names not working anymore, which requires some fixes in the package
repositories.
Signed-off-by: Matthias Schiffer
---
scripts/package-metadata.pl | 60
Package "features" seem to be unused for some time. In any case, custom
Config.in snippets and package PROVIDES are a much more flexible way to
express similar options.
Signed-off-by: Matthias Schiffer
---
include/package-dumpinfo.mk | 25 -
scripts/m
This feature has been unused for years, and its scope is too limited to be
actually useful.
Signed-off-by: Matthias Schiffer
---
include/package-dumpinfo.mk | 16 +---
package/Makefile| 3 ---
scripts/metadata.pm | 20 +---
scripts/package
Instead of adding virtual packages to the normal package list, keep a
separate list for provides, make each package provide itself, and resolve
all dependencies through this list. This allows to use PROVIDES to replace
existing packages.
Fixes FS#837.
Signed-off-by: Matthias Schiffer
Signed-off-by: Matthias Schiffer
---
scripts/feeds | 20 +++-
scripts/metadata.pm | 6 +++---
scripts/package-metadata.pl | 16 +++-
3 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/scripts/feeds b/scripts/feeds
index 42f7b3b116
On 01/08/2018 03:52 PM, Matthias Schiffer wrote:
> When attempting to fix FS#837, I decided to treat our metadata generator to
> a greater refactoring, which resulted in this patchset. FS#837 is fixed in
> patch 13.
>
> I also removed two seemingly obsolete features, "pre
1 - 100 of 160 matches
Mail list logo