Re: [LEDE-DEV] [PATCH][opkg] add opkg option http_timeout

2017-12-12 Thread John Crispin
Hi Lynxis, patch is missing the SoB line. please fix/resend     John On 04/12/17 17:48, Alexander Couzens wrote: http_timeout will append `--timeout xy` to the resulting wget call. This is useful when using opkg update in a automatic way and prevent long timeouts --- libopkg/opkg_conf.c

[LEDE-DEV] odhcpd vs odhcpd-ipv6only

2017-12-12 Thread Mauro Mozzarelli
Hello, I understand that odhcpd-ipv6only has now become the default and it conflicts with odhcpd. Please could you let me know if odhcpd-ipv6only supports the existing configuration file /etc/config/dhcp? And what if I have an ipv4 only LAN? What was the rationale for the switch? And fi

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread John Crispin
On 02/12/17 00:26, Roman Yeryomin wrote: Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin Hi Roman, The code needs to stay like this. the moment you start the command with redirection, the shell wil

[LEDE-DEV] [PATCH] base-files: add comment to uci-defaults.sh script

2017-12-12 Thread John Crispin
add comment explaining why we generate board.json in 2 steps Signed-off-by: John Crispin --- package/base-files/files/lib/functions/uci-defaults.sh | 4 1 file changed, 4 insertions(+) diff --git a/package/base-files/files/lib/functions/uci-defaults.sh b/package/base-files/files/lib/funct

Re: [LEDE-DEV] [PATCH] base-files: add comment to uci-defaults.sh script

2017-12-12 Thread Matthias Schiffer
On 12/12/2017 11:24 AM, John Crispin wrote: > > > board_config_flush() { > + # when calling json_dump with a redirect, the shell will truncate the > target > + # file and not update it until a close/flush is called. this results in > a short > + # window where the file is 0 bytes.

Re: [LEDE-DEV] odhcpd vs odhcpd-ipv6only

2017-12-12 Thread Matthias Schiffer
Unless you have the option odhcpd_is_main in /etc/config/dhcp, odhcpd has never been used for IPv4, but only for DHCPv6; IPv4 DHCP is handled by dnsmasq by default. The switch to odhcpd-ipv6only simply removes some unused clutter from our default package set. Regards, Matthias On 12/12/2017 11:1

Re: [LEDE-DEV] odhcpd vs odhcpd-ipv6only

2017-12-12 Thread Mathias Kresin
2017-12-12 11:15 GMT+01:00 Mauro Mozzarelli : > Hello, > > I understand that odhcpd-ipv6only has now become the default and it > conflicts with odhcpd. > > Please could you let me know if odhcpd-ipv6only supports the existing > configuration file /etc/config/dhcp? Yes, the default config works as

Re: [LEDE-DEV] [PATCH] ar71xx: add support for Comfast CF-E312A V2

2017-12-12 Thread John Crispin
Hi, two comments inline ... On 06/12/17 20:37, bmoff...@bmoffitt.com wrote: The Comfast CF-E312A V2 is a 5 GHz radio with a built-in directional antenna, much like a Ubiquiti NanoStation M5. Specifiation: - SoC: AR9344 at 650 MHz - Flash: 16 MiB (W25Q128FVSG) - RAM: 64 MiB DDR2 (W9751G6KB) -

Re: [LEDE-DEV] [PATCH] jshn: add functionality to read big JSON

2017-12-12 Thread John Crispin
Hi Christian, small formatting nitpick inline ... On 16/11/17 19:52, Christian Beier wrote: The existing read functionality feeds the complete JSON to jshn as a cmdline argument, leading to `-ash: jshn: Argument list too long` errors for JSONs bigger than ca. 100KB. This commit adds the abili

Re: [LEDE-DEV] [PATCH 1/2] tools/sstrip: Fix compile under standard linux.

2017-12-12 Thread John Crispin
On 23/11/17 22:18, Rosen Penev wrote: bswap32 undefined is the issue. Added the proper header. Also fixed a few format/conversion warnings that clang complained about without -Wall or -Wextra. the description is sub optimal and more than 75 chars. please add the full error output of your co

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread Felix Fietkau
On 2017-12-12 11:19, John Crispin wrote: > > > On 02/12/17 00:26, Roman Yeryomin wrote: >> Moving a file between tmpfs and other fs is neither >> faster nor safer, thus no point in doing it in two steps. >> >> Signed-off-by: Roman Yeryomin > > Hi Roman, > > The code needs to stay like this. th

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread John Crispin
On 12/12/17 12:37, Felix Fietkau wrote: On 2017-12-12 11:19, John Crispin wrote: On 02/12/17 00:26, Roman Yeryomin wrote: Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin Hi Roman, The code needs t

Re: [LEDE-DEV] [netifd] Fix incorrect eui64 IPv6 address with ula prefix for br-lan

2017-12-12 Thread John Crispin
On 04/12/17 07:04, wendy2001...@163.com wrote: From: Wendy Wu Issue description: Configurate /etc/config/network, Set the ula_prefix in globals section, config globals 'globals' option ula_prefix 'fdc7:8830:f3be::/48' Add the following option in 'lan' interface, option ip6ifaceid 'eu

[LEDE-DEV] New lede->openwrt build, missing ubifs firmware build

2017-12-12 Thread Mauro Mozzarelli
...again, on the latest changes... I noticed the firmware now builds with "openwrt" prefix instead of "lede". I am building for xrx200 lantiq (BT Home Hub 5). With previous LEDE builds I used to get both ubifs and squashfs firmware versions built. Now I get only squashfs. Is there a new conf

Re: [LEDE-DEV] New lede->openwrt build, missing ubifs firmware build

2017-12-12 Thread Mauro Mozzarelli
Why not leave it as a configurable (in .config) option? ubifs is faster On 12/12/17 12:56, Mauro Mozzarelli wrote: ...again, on the latest changes... I noticed the firmware now builds with "openwrt" prefix instead of "lede". I am building for xrx200 lantiq (BT Home Hub 5). With previous L

[LEDE-DEV] [PATCH] base-files: allow skipping of hash verification

2017-12-12 Thread John Crispin
From: Jo-Philipp Wich When calling a download target, hash verification is now completely skipped if we set PKG_HASH=none. This allows to easily bump package version: $ make package//download PKG_HASH=none V=s $ make package//check FIXUP=1 V=s This will download the new version of the package,

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread John Crispin
On 03/10/17 09:16, Rosen Penev wrote: ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in case of failure, so adjust to kernel default. Signed-off-by: Rosen Penev --- defaults.c | 1 + 1 file changed, 1 insertion(+) diff --git a/defaults.c b/defaults.c index 85a3750..6

Re: [LEDE-DEV] New lede->openwrt build, missing ubifs firmware build

2017-12-12 Thread Arjen de Korte
Citeren Mauro Mozzarelli : ...again, on the latest changes... I noticed the firmware now builds with "openwrt" prefix instead of "lede". I am building for xrx200 lantiq (BT Home Hub 5). With previous LEDE builds I used to get both ubifs and squashfs firmware versions built. Now I get only

Re: [LEDE-DEV] [PATCH] base-files: allow skipping of hash verification

2017-12-12 Thread Jo-Philipp Wich
Hi John, thanks for taking care of it. I have a minor change request, can we swap "none" with "skip"? I think that makes slightly more sense in this context. ~ Jo ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman

Re: [LEDE-DEV] [PATCH] base-files: allow skipping of hash verification

2017-12-12 Thread John Crispin
On 12/12/17 16:13, Jo-Philipp Wich wrote: Hi John, thanks for taking care of it. I have a minor change request, can we swap "none" with "skip"? I think that makes slightly more sense in this context. ~ Jo ___ Lede-dev mailing list Lede-dev@lists.in

Re: [LEDE-DEV] Uniform cryptography library

2017-12-12 Thread Matthias-Christian Ott
On 2017-12-12 01:12, Moritz Warning wrote: > On 12/11/2017 07:10 PM, Matthias-Christian Ott wrote: > [..] >> Do you think it would be worth the effort to unify the cryptography >> libraries in LEDE? > > This sounds like a huge task. It is and needs a conscious commitment and decision of the proje

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread Rosen Penev
On Tue, Dec 12, 2017 at 6:07 AM, John Crispin wrote: > > > On 03/10/17 09:16, Rosen Penev wrote: >> >> ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in >> case of failure, so adjust to kernel default. >> >> Signed-off-by: Rosen Penev >> --- >> defaults.c | 1 + >> 1 file

Re: [LEDE-DEV] [PATCH] firewall3: Enable TCP_ECN by default.

2017-12-12 Thread Rosen Penev
resent since gmail sucks. On Tue, Dec 12, 2017 at 10:34 AM, Rosen Penev wrote: > On Tue, Dec 12, 2017 at 6:07 AM, John Crispin wrote: >> >> >> On 03/10/17 09:16, Rosen Penev wrote: >>> >>> ECN is used by fq_codel and other AQMs. Kernel 4.2 added a fallback in >>> case of failure, so adjust to ke

Re: [LEDE-DEV] Uniform cryptography library

2017-12-12 Thread Moritz Warning
On 12/12/2017 06:48 PM, Matthias-Christian Ott wrote: > On 2017-12-12 01:12, Moritz Warning wrote: >> On 12/11/2017 07:10 PM, Matthias-Christian Ott wrote: >> [..] >>> Do you think it would be worth the effort to unify the cryptography >>> libraries in LEDE? >> >> This sounds like a huge task. > >

Re: [LEDE-DEV] [PATCH] jshn: add functionality to read big JSON

2017-12-12 Thread Christian Beier via Lede-dev
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Am Tue, 12 Dec 2017 12:03:50 +0100

Re: [LEDE-DEV] [PATCH] fstools: Fix some errors detected by cppcheck

2017-12-12 Thread Rosen Penev
On Mon, Dec 11, 2017 at 1:22 PM, Arjen de Korte wrote: > Citeren Jonas Gorski : > >> On 11 December 2017 at 10:04, Rosen Penev wrote: >>> >>> Mainly plugging memory leaks. Size reduction as well. The calloc change >>> accounts for 272 bytes on this machine for some reason... >> >> >> Please state

[LEDE-DEV] [PATCH] tools/sstrip: Fix compile under standard linux.

2017-12-12 Thread Rosen Penev
bswap32 undefined is the issue. Added the proper header. Also fixed a few format/conversion warnings that clang complained about without -Wall or -Wextra. Command to compile was "clang sstrip.c" (output is a.out) Multiple instances of these warnings were thrown. sstrip.c:365:1: warning: format

[LEDE-DEV] [PATCH] wireguard: bump to 20171211

2017-12-12 Thread Kevin Darbyshire-Bryant
Bump to latest WireGuard snapshot release: 44f8e4d version: bump snapshot bbe2f94 chacha20poly1305: wire up avx512vl for skylake-x 679e53a chacha20: avx512vl implementation 10b1232 poly1305: fix avx512f alignment bug 5fce163 chacha20poly1305: cleaner generic code 63a0031 blake2s-x86_64: fix spacin

Re: [LEDE-DEV] [PATCH] ar71xx: add support for TP-Link TL-WDR7500v6

2017-12-12 Thread Piotr Dymacz
Hello Bill, On 30.11.2017 22:06, Bill Moffitt wrote: Piotr- Good points all... [snip] In general, of course, I agree. However, we are seeing an increasing number of vendors (TP-Link and Ubiquiti, to name 2) using some form of locking in the bootloader to prevent loading of third-party firmw

Re: [LEDE-DEV] [PATCH] ar71xx: add support for Comfast CF-E312A V2

2017-12-12 Thread Piotr Dymacz
Hello Bill, Please see below some more comments (excluding those from John). I closed your PR on GitHub [1] as it's a copy of your patch (there is no need to send it here and on GitHub). On 06.12.2017 20:37, bmoff...@bmoffitt.com wrote: The Comfast CF-E312A V2 is a 5 GHz radio with a built-i

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Piotr Dymacz
Hi Jo, On 01.12.2017 14:37, Jo-Philipp Wich wrote: Hi, I still have here some concerns/thoughts: 1. I don't know how to deal in above approach with region variant images but I'm sure we should _somehow_ separate region code from boardname and other parts of the image filename. IMHO, dash char

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Jo-Philipp Wich
Hi Piotr, my rough idea was to somehow tie the manifest generation to the "define Device/*" macros present in the image building code because there you have all required information in a central place: - unique board identifier - image name / build steps - default package selection ~ Jo

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Piotr Dymacz
Hi Mathias, On 01.12.2017 16:12, Mathias Kresin wrote: Hey Piotr , thanks a lot for thinking about my proposal. Sorry for a very late reply. 2017-12-01 14:30 GMT+01:00 Piotr Dymacz : On 29.11.2017 09:33, Mathias Kresin wrote: 1. fix the compatible strings in the DTS files I think we sho

[LEDE-DEV] [PATCH] ar71xx: fix invalid pointer dereference in rb95x_nand_scan_fixup()

2017-12-12 Thread Gabor Juhos
Since Linux 4.6, mtd->priv no longer points to the NAND specific structure. Under 4.9 it contains NULL, thus using it to access chip->options causes an invalid pointer dereference (FS#1200). Update the code to use the mtd_to_nand() helper under 4.9 to obtain the address of the chip specific data.

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
Hey Daniel, sorry for the late reply, I totally missed your mail and only spotted it due to the recent replies. 01.12.2017 22:20, Daniel Golle: On Wed, Nov 29, 2017 at 09:33:39AM +0100, Mathias Kresin wrote: 28.11.2017 19:24, Daniel Golle: Hi Moritz, thanks for stepping forward and adressi

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
12.12.2017 21:02, Piotr Dymacz: On 01.12.2017 16:12, Mathias Kresin wrote: I really doubt that upstream is going to accept vendor prefixes if they aren't used anywhere. I would prefer to use what already exists, add our own prefixes where required and upstream them at the time the dts is send up

Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Rafał Miłecki
On 15 August 2017 at 12:49, Rafał Miłecki wrote: > From: Rafał Miłecki > > Example frequency: > { > "channel": 1, > "mhz": 2412, > "restricted": false, > "active": false, > "restrictions": { > "no_ht40minus": true, > "no_80mh

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Jonas Gorski
On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: > Hi Piotr, > > my rough idea was to somehow tie the manifest generation to the "define > Device/*" macros present in the image building code because there you > have all required information in a central place: > > - unique board identifier >

Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jo-Philipp Wich
Hi Rafał, in principle fine with me - but I guess all restrictions will be in the form { : true } so I'd rather make it an array. Also since a restriction implies something not possible, I'd drop the "no_" prefix too. So in the end it would look like: { "channel": 1, "mhz": 2412, "restrict

[LEDE-DEV] [PATCH v2 0/1] at91: sdcard image patch Summary

2017-12-12 Thread Sandeep Sheriker Mallikarjun
This patch is about generating sdcard images for at91 sama5 socs. v1->v2: v1 patch was Superseded. re-submiting again. Sandeep Sheriker Mallikarjun (1): at91: create sdcard image for sama5 .../image/gen_at91_sdcard_img.sh} | 4 +- target/linux/at91/image/sama5.mk

[LEDE-DEV] [PATCH v2 1/1] at91: create sdcard image for sama5

2017-12-12 Thread Sandeep Sheriker Mallikarjun
create sdcard image using gen_at91_sdcard_img.sh for sama5 platform and sdcard image partition layout is: P0: Boot (fat32) - contains(at91bootstrap,u-boot,zImage & dtb) p1: Rootfs (ext4) Signed-off-by: Sandeep Sheriker Mallikarjun --- .../image/gen_at91_sdcard_img.sh} | 4

Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jonas Gorski
Hi, On 12 December 2017 at 23:05, Jo-Philipp Wich wrote: > Hi Rafał, > > in principle fine with me - but I guess all restrictions will be in the > form { : true } so I'd rather make it an array. > > Also since a restriction implies something not possible, I'd drop the > "no_" prefix too. So in th

Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

2017-12-12 Thread Jonas Gorski
On 12 December 2017 at 23:13, Jo-Philipp Wich wrote: > Hi, > >> I'd argue the no_ prefix makes it more clear that these restrictions >> say what is prohibited, not what is allowed. > > What about calling it "prohibit" instead of "restrictions" then? That > would make it both terse and unambiguous.

Re: [LEDE-DEV] [PATCH] ar71xx: fix invalid pointer dereference in rb95x_nand_scan_fixup()

2017-12-12 Thread Arjen de Korte
Citeren Gabor Juhos : Since Linux 4.6, mtd->priv no longer points to the NAND specific structure. Under 4.9 it contains NULL, thus using it to access chip->options causes an invalid pointer dereference (FS#1200). Update the code to use the mtd_to_nand() helper under 4.9 to obtain the address of

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Matthias Schiffer
On 12/12/2017 11:01 PM, Jonas Gorski wrote: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required information in

Re: [LEDE-DEV] fixing of image file names

2017-12-12 Thread Mathias Kresin
12.12.2017 23:01, Jonas Gorski: > On 12 December 2017 at 21:03, Jo-Philipp Wich wrote: >> Hi Piotr, >> >> my rough idea was to somehow tie the manifest generation to the "define >> Device/*" macros present in the image building code because there you >> have all required information in a central

Re: [LEDE-DEV] [PATCH 00/25] Add support for kernel 4.14

2017-12-12 Thread Hauke Mehrtens
On 12/10/2017 11:12 PM, Hauke Mehrtens wrote: > This adds support for kernel 4.14 to LEDE. > This ports the generic patches to kernel 4.14 and also adds support for > kernel 4.14 to the x86 target, I am also working on adding support for > the lantiq target, but there are still some problems with