Re: [LEDE-DEV] [PATCH 1/2] fstools: Replace strerror(errno) with %m format.

2017-12-10 Thread Arjen de Korte
Citeren Rosen Penev : Saves 1472 bytes under glibc. No other difference. Except that this is GNU C only. I'm not sure if this is worth breaking portability. It would probably be better to put these changes in appropriate #ifdef/#else/#endif to only use this if GNU C is used. Signed-off-

Re: [LEDE-DEV] compile hostapd/wpa_supplicant with mesh and sae options

2017-12-10 Thread Felix Fietkau
On 2017-12-09 21:51, Carlito Nueno wrote: > I need WPA2 Enterprise and I also want to try / implement 802.11r. > > I am attaching the log errors, wap_supplicant.conf, part of wireless > config: https://gist.github.com/ironpillow/e0779261f6d045a6883f5dbd6ae81c1f > > I don't get the above errors wh

[LEDE-DEV] [PATCH 0/3] busybox Makefile improvements (fix hardening)

2017-12-10 Thread Matthias Schiffer
When streamlining our busybox Makefile a bit, I noticed that we don't properly pass TARGET_CPPFLAGS and TARGET_LDFLAGS. This is fixed in patch 3/3, which unfortunately increases the binary size by a bit (see commit message for details). I think applying the patch makes sense, so the hardening is a

[LEDE-DEV] [PATCH 1/3] include/package.mk: remove old configured stamps before attempting configuration

2017-12-10 Thread Matthias Schiffer
Some packages, e.g. busybox, explicitly remove old .configured stamps before attempting configuration, rather than after the actual configuration step. This seems like a good idea, as there will be no stamp left if configuration fails. Change generic rules to work like this, so package- specific ru

[LEDE-DEV] [PATCH 3/3] busybox: add missing TARGET_CPPFLAGS and TARGET_LDFLAGS

2017-12-10 Thread Matthias Schiffer
Unconditionally pass TARGET_CPPFLAGS (not passed at all before) and TARGET_LDFLAGS (passed only in certain non-default configuration before the Makefile streamlining). Without these flags, hardening options (PKG_FORTIFY_SOURCE and PKG_RELRO) were not actually applied to busybox. The addition of th

[LEDE-DEV] [PATCH 2/3] busybox: streamline Makefile

2017-12-10 Thread Matthias Schiffer
Use default Build/Install steps where possible. No binary change in default configuration, so PKG_RELEASE is not incremented. Signed-off-by: Matthias Schiffer --- package/utils/busybox/Makefile | 67 +++--- 1 file changed, 17 insertions(+), 50 deletions(-) di

Re: [LEDE-DEV] [PATCH 2/2] fstools: Fix some errors detected by cppcheck

2017-12-10 Thread Arjen de Korte
Citeren Rosen Penev : Mainly plugging memory leaks. Size reduction as well. The calloc change accounts for 272 bytes on this machine for some reason... Comments inline. Signed-off-by: Rosen Penev --- block.c | 6 +++--- blockd.c | 3 +++ libfstools/overl

Re: [LEDE-DEV] compile hostapd/wpa_supplicant with mesh and sae options

2017-12-10 Thread Felix Fietkau
On 2017-12-10 20:03, Carlito Nueno wrote: > So wpad-mesh can do WPA2 enterprise, EAP and radius? I thought it was > like wpad-mini plus 80211s features.  It's like wpad + 802.11s, so it should be able to do what you need. - Felix ___ Lede-dev mailing li

Re: [LEDE-DEV] Adding firewall extensions for xt_geoip usage

2017-12-10 Thread Philip Prindeville
> On Dec 9, 2017, at 1:33 AM, Arjen de Korte wrote: > > Citeren Philip Prindeville : > >> Jo and others: >> >> Is there an easy way to extend firewall rules? I’d like to add support to >> blocking on a per-country basis, possibly with qualified exceptions. > > Take a look at /etc/firewall.

Re: [LEDE-DEV] [PATCH 1/2] fstools: Replace strerror(errno) with %m format.

2017-12-10 Thread Felix Fietkau
On 2017-12-10 13:54, Arjen de Korte wrote: > Citeren Rosen Penev : > >> Saves 1472 bytes under glibc. No other difference. > > Except that this is GNU C only. I'm not sure if this is worth breaking > portability. It would probably be better to put these changes in > appropriate #ifdef/#else/#

Re: [LEDE-DEV] [PATCH 2/2] fstools: Fix some errors detected by cppcheck

2017-12-10 Thread Rosen Penev
Reposting since gmail sucks: On Sun, Dec 10, 2017 at 10:17 AM, Arjen de Korte wrote: > Citeren Rosen Penev : > >> Mainly plugging memory leaks. Size reduction as well. The calloc change >> accounts for 272 bytes on this machine for some reason... > > > Comments inline. > >> Signed-off-by: Rosen P

Re: [LEDE-DEV] [PATCH 1/7] ag71xx: Reorder some more structs based on warmth.

2017-12-10 Thread Karl Palsson
Rosen Penev wrote: > Should help slightly. That's not really very encouraging. Surely you have a test setup if you're actually looking at making performance related changes? You should have actual numbers on changes, otherwise this is just poking in chicken entrails. Sincerely, Karl Palsson >

[LEDE-DEV] [PATCH 07/25] kernel: add kmod-dax

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-dm depends on kmod-dax. Add DAX: "Direct access to differentiated memory" to LEDE. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/block.mk | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/block.mk

[LEDE-DEV] [PATCH 02/25] kernel: generic: add some more 4.9 configure options

2017-12-10 Thread Hauke Mehrtens
These are taken from the x86 target and should make support kernel 4.9 and 4.14 in the x86 target easier. Signed-off-by: Hauke Mehrtens --- target/linux/generic/config-4.9 | 9 + 1 file changed, 9 insertions(+) diff --git a/target/linux/generic/config-4.9 b/target/linux/generic/config-4

[LEDE-DEV] [PATCH 06/25] kernel: tg3: deactivate hwmon for kernel 4.14

2017-12-10 Thread Hauke Mehrtens
On kernel 4.14 hwmon support can be deactivated for the tg3 driver, deactivate it by default to save some space on the brcm47xx platform. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/netdevices.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/

[LEDE-DEV] [PATCH 01/25] xtables-addons: update to version 2.14

2017-12-10 Thread Hauke Mehrtens
This includes one compile fix needed for kernel 4.14. Signed-off-by: Hauke Mehrtens --- package/network/utils/xtables-addons/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/network/utils/xtables-addons/Makefile b/package/network/utils/xtables-addons/Make

[LEDE-DEV] [PATCH 09/25] kernel: add kmod-crypto-acompress

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-crypto-deflate depends on kmod-crypto-acompress. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/crypto.mk | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/crypto.mk b/package/kernel/linux/modules/

[LEDE-DEV] [PATCH 08/25] kernel: add kmod-lib-zstd

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-fs-btrfs depends on the zstd compression libraries, add it to the package system. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/fs.mk | 2 +- package/kernel/linux/modules/lib.mk | 22 ++ 2 files changed, 23 insertions(+), 1 deletion(-)

[LEDE-DEV] [PATCH 00/25] Add support for kernel 4.14

2017-12-10 Thread Hauke Mehrtens
This adds support for kernel 4.14 to LEDE. This ports the generic patches to kernel 4.14 and also adds support for kernel 4.14 to the x86 target, I am also working on adding support for the lantiq target, but there are still some problems with the xrx200 Ethernet driver. I would like to use this

[LEDE-DEV] [PATCH 21/25] kernel: kmod-rtc-ds1307: add dependency to regmap

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-rtc-ds1307 depends on regmap-i2c, add this missing dependency. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/other.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/oth

[LEDE-DEV] [PATCH 03/25] x86: refresh configuration

2017-12-10 Thread Hauke Mehrtens
Just refresh the kernel configuration, some options are removed because they are now in the generic kernel configuration. Signed-off-by: Hauke Mehrtens --- target/linux/x86/64/config-default | 10 -- target/linux/x86/generic/config-default | 7 --- target/linux/x86/geode/config

[LEDE-DEV] [PATCH 14/25] kernel: kmod-rxrpc: handle renamed kernel module

2017-12-10 Thread Hauke Mehrtens
The kernel module was renamed with kernel 4.11, handle that in the package definition. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/netsupport.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kerne

[LEDE-DEV] [PATCH 22/25] kernel: add missing dependencies to kmod-crypto-acompress

2017-12-10 Thread Hauke Mehrtens
kmod-lib-lzo and kmod-lib-lz4 depend in kernel 4.14 on kmod-crypto-acompress, add this missing dependency. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/lib.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/kernel/linux/modules/lib.mk b/package/kernel/linux/modul

[LEDE-DEV] [PATCH 18/25] xtables-addons: fix compile with kernel 4.14

2017-12-10 Thread Hauke Mehrtens
This fixes a compile problems seen with kernel 4.14. Signed-off-by: Hauke Mehrtens --- .../utils/xtables-addons/patches/201-fix-lua-packetscript.patch | 9 + 1 file changed, 9 insertions(+) diff --git a/package/network/utils/xtables-addons/patches/201-fix-lua-packetscript.patch b/pac

[LEDE-DEV] [PATCH 19/25] kernel: kmod-zram: deactivate CONFIG_ZRAM_WRITEBACK for kernel 4.14

2017-12-10 Thread Hauke Mehrtens
This new option was introduced in kernel 4.14 and should be deactivated by default. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/other.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk index ef2

[LEDE-DEV] [PATCH 12/25] kernel: unset CONFIG_CIFS_SMB311 in kmod-fs-cifs

2017-12-10 Thread Hauke Mehrtens
Do not activate the experimental feature CONFIG_CIFS_SMB311. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/fs.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/fs.mk b/package/kernel/linux/modules/fs.mk index 1e130ddac6..f7575

[LEDE-DEV] [PATCH 10/25] kernel: add kmod-crypto-rsa

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-crypto-hw-ccp depends on kmod-crypto-rsa, add it. kmod-crypto-rsa also packages the ASN1 parser and some other code which is currently only used by this module. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/crypto.mk | 22 -- 1 file change

[LEDE-DEV] [PATCH 23/25] kernel: include: remove last .0 from kernel versions again

2017-12-10 Thread Hauke Mehrtens
Kernel 4.14 has the version number 4.14 and not 4.14.0. This changed again with some more recent kernel versions. This change makes it possible to use kernel 4.14 without any minor version. Signed-off-by: Hauke Mehrtens --- include/kernel.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[LEDE-DEV] [PATCH 13/25] kernel: deactivate some new network features

2017-12-10 Thread Hauke Mehrtens
This deactivates the following options which were introduced between kernel 4.9 and 4.14 in some kernel packages: CONFIG_INET_ESP_OFFLOAD CONFIG_INET6_ESP_OFFLOAD CONFIG_LWTUNNEL_BPF CONFIG_NET_9P_XEN Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/netsupport.mk | 8 ++-- 1 fi

[LEDE-DEV] [PATCH 16/25] kernel: kmod-sound-core: handle moved snd-seq-device.ko

2017-12-10 Thread Hauke Mehrtens
The snd-seq-device.ko kernel module was moved with kernel 4.13. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/sound.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/sound.mk b/package/kernel/linux/modules/sound.mk index 75aa3

[LEDE-DEV] [PATCH 17/25] kernel: kmod-fbcon: deactivate for kernel 4.14

2017-12-10 Thread Hauke Mehrtens
CONFIG_FRAMEBUFFER_CONSOLE does not activate new modules any more in kernel 4.14, but CONFIG_FRAMEBUFFER_CONSOLE is now a boolean option which change the kmod-fb package. kmod-fbcon should be split up. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/video.mk | 2 +- 1 file changed

[LEDE-DEV] [PATCH 20/25] kernel: kmod-iio-bmp280: allow compile with kernel 4.14

2017-12-10 Thread Hauke Mehrtens
This package also compiles with kernel 4.14. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/iio.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/iio.mk b/package/kernel/linux/modules/iio.mk index 396ee7fbe4..8990e54813 100644 --

[LEDE-DEV] [PATCH 15/25] kernel: kmod-mmc: handle moved mmc_block.ko

2017-12-10 Thread Hauke Mehrtens
mmc_block.ko was moved with kernel 4.10. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/other.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/other.mk b/package/kernel/linux/modules/other.mk index b3ad4a051e..ef2740296a 10064

[LEDE-DEV] [PATCH 11/25] kernel: add kmod-crypto-ecdh

2017-12-10 Thread Hauke Mehrtens
In kernel 4.14 kmod-bluetooth depends on kmod-crypto-ecdh, add kmod-crypto-ecdh to LEDE. Both packages also depend on the kmod-crypto-kpp package. To build this we have to fix the dependency of CRYPTO_ECDH which has a typo. Signed-off-by: Hauke Mehrtens --- package/kernel/linux/modules/crypto.mk

[LEDE-DEV] [PATCH 24/25] x86: copy kernel 4.9 patches and config to 4.14

2017-12-10 Thread Hauke Mehrtens
This just copies the configuration and the patches from kernel 4.9 to the places where they are expected for kernel 4.14 without modifying them. Signed-off-by: Hauke Mehrtens --- target/linux/x86/{config-4.9 => config-4.14} | 0 .../linux/x86/{patches-4.9 => patches-

[LEDE-DEV] [PATCH 04/25] kernel: generic: copy kernel 4.9 patches and config to 4.14

2017-12-10 Thread Hauke Mehrtens
This is the initial step to add kernel 4.14 support by copying the patches and configuration used for kernel 4.9 to the folders which should be used for kernel 4.14. I did no modifications to the code. Signed-off-by: Hauke Mehrtens --- .../010-Kbuild-don-t-hardcode-path-to-awk-in-scripts-ld-vers

[LEDE-DEV] [PATCH 25/25] x86: update config and make patches apply for kernel 4.14

2017-12-10 Thread Hauke Mehrtens
This updates the configuration and makes the kernel patches apply against kernel 4.14. The subtarget configuration was refresh with kernel 4.14 and the options needed to make it compile on kernel 4.9 were added manually. Signed-off-by: Hauke Mehrtens --- target/linux/x86/64/config-default

Re: [LEDE-DEV] compile hostapd/wpa_supplicant with mesh and sae options

2017-12-10 Thread Carlito Nueno
I am testing with wpad-mesh and nodes are connecting and I can ping each node, but logread shows below notice ONLY when mesh iface has encryption on. Mon Dec 11 02:54:38 2017 daemon.notice hostapd: handle_probe_req: send failed Mon Dec 11 02:54:38 2017 daemon.notice hostapd: handle_probe_req: send

Re: [LEDE-DEV] compile hostapd/wpa_supplicant with mesh and sae options

2017-12-10 Thread Carlito Nueno
I just noticed that when mesh is enabled on wlan0, the ap part does not work. wlan0-ap does not broadcast ssid. this is using the wpad-mesh package. config wifi-iface 'wlan0_ap_radio0' option mode 'ap' option device 'radio0' option network 'lan' option ifname 'wlan