Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Paul Oranje
M2C: Wiki's are wonderful for documentation purposes as it allows anyone to attribute without much difficulty. But how to ensure that the documentation follows project code changes ? Add to https://lede-project.org/submitting-patches the instruction that any change that would have consequences

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Javier Domingo Cansino
> The wiki is working for me. it's great to have the ToH. Also the device pages > are great. However the wiki is not always completely correct and may be just > wrong. It's a wiki, change it! A wiki is always changing. Just in case, we are not loosing the ToH, it's just that I didn't implement i

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Alberto Bursi
On 11/11/2017 01:40 AM, Javier Domingo Cansino wrote: Hello, I have continued working on the docs https://lede.rtfd.io. It now contains a Proof of Concept, with the following features: * Documentation can be exported in different formats, html (hosted in https://lede.rtfd.io), single page htm

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Sebastian Moeller
Dear Javier, first of, I am just a very casual contributor; only added a few details to the sqm user guide, so I do not assume my word having much weight. Well, just from my perspective, if I had to create PRs for my changes and additions to the sqm user guide, I certainly would not have made o

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Javier Domingo Cansino
> Editing the page happens through Github's web editor and web interface, > both are utter garbage for code, and even more so for text-based > documentation. Plus the whole fact that you are required to open a PR, > which is a completely alien concept for non-developers. If someone has an small ch

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Sebastian Moeller
Hi Javiet, > On Nov 12, 2017, at 22:24, Javier Domingo Cansino wrote: > >> Editing the page happens through Github's web editor and web interface, >> both are utter garbage for code, and even more so for text-based >> documentation. Plus the whole fact that you are required to open a PR, >> whi

Re: [LEDE-DEV] Lede/Openwrt documentation

2017-11-12 Thread Javier Domingo Cansino
> But it seems like a) way more hassle than editing a wiki directly and > b) requires a github account. The github account is the same as the wiki account, but I do agree that is more hassle mainly because it's not an integrated experience > I do some stuff with github, but so fa

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-12 Thread rosenp
On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: > Citeren Rosen Penev : > > > Less verbose. > > And uses a GCC extension which makes it less portable. ISO C > forbids > empty initializer braces [1]. See for yourself by adding the > -pedantic > flag to your CFLAGS. The correct way to

Re: [LEDE-DEV] [PATCH] ubox: Remove unnecessary memset calls.

2017-11-12 Thread rosenp
Just retested. This patch lowers size on x86 from 52144 to 52072 On Tue, 2017-11-07 at 12:22 -0800, Rosen Penev wrote: > Change to calloc instead. Less verbose. > > Signed-off-by: Rosen Penev > --- > log/syslog.c | 4 +--- > lsbloader.c | 3 +-- > 2 files changed, 2 insertions(+), 5 deletions(

Re: [LEDE-DEV] [PATCH] procd: Remove unnecessary memset calls.

2017-11-12 Thread rosenp
Tested compile size difference. Saves 32 bytes. ¯\_(ツ)_/¯ On Tue, 2017-11-07 at 12:05 -0800, Rosen Penev wrote: > Changes allocation to calloc and {} as needed. > > Signed-off-by: Rosen Penev > --- > inittab.c | 6 ++ > plug/hotplug.c | 7 ++- > 2 files changed, 4 insertions(+), 9

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-12 Thread Eric Luehrsen
On 11/12/2017 09:49 PM, ros...@gmail.com wrote: On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: Citeren Rosen Penev : Less verbose. And uses a GCC extension which makes it less portable. ISO C forbids empty initializer braces [1]. See for yourself by adding the -pedantic flag to your

Re: [LEDE-DEV] [PATCH] procd: Remove unnecessary memset calls.

2017-11-12 Thread Eric Luehrsen
On 11/12/2017 10:53 PM, ros...@gmail.com wrote: Tested compile size difference. Saves 32 bytes. ¯\_(ツ)_/¯ On Tue, 2017-11-07 at 12:05 -0800, Rosen Penev wrote: Changes allocation to calloc and {} as needed. Signed-off-by: Rosen Penev --- inittab.c | 6 ++ plug/hotplug.c | 7 ++