Re: [LEDE-DEV] [PATCH ubox] Fix logger starvation and Add feature log priority filtering

2017-07-05 Thread Hans Dedecker
On Tue, Jul 4, 2017 at 8:33 PM, Ron Brash wrote: > Hello all, > > We had an issue with a customer's recent deployment and needed to > perform the following: > * Add a syslog filtering functionality into the logger > * Fix a condition where ubox's logd would continue running, but needed > to be res

Re: [LEDE-DEV] [PATCH] packages: update triggerhappy to version 0.5.0 and fix licence tag

2017-07-05 Thread Stefan Tomanek
Dies schrieb Hauke Mehrtens (ha...@hauke-m.de): > On 06/25/2017 05:14 PM, Stefan Tomanek wrote: > > Tested on TP-Link Archer C7 > > > > Signed-off-by: Stefan Tomanek > > --- > > utils/triggerhappy/Makefile |9 - > > 1 file changed, 4 insertions(+), 5 deletions(-) > > The package fe

Re: [LEDE-DEV] [PATCH ubox] Fix logger starvation and Add feature log priority filtering

2017-07-05 Thread Rafał Miłecki
On 4 July 2017 at 20:33, Ron Brash wrote: > This communication is intended for the use of the recipient to which it is > addressed, and may contain confidential, personal, and or privileged > information. Please contact the sender immediately if you are not the > intended recipient of this communi

[LEDE-DEV] [PATCH][ubus] ubusd_monitor: alloc & free the buffer outside of the loop

2017-07-05 Thread Alexandru Ardelean
From: Alexandru Ardelean Should save a few cycles, since the data that's being changed is only the seq number. And the `ub` is always created as shared. Signed-off-by: Alexandru Ardelean --- ubusd_monitor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ubusd_monit

Re: [LEDE-DEV] [PATCH][ubus] ubusd_monitor: alloc & free the buffer outside of the loop

2017-07-05 Thread Alexandru Ardelean
On Wed, Jul 5, 2017 at 4:12 PM, Alexandru Ardelean wrote: > From: Alexandru Ardelean > > Should save a few cycles, since the data that's > being changed is only the seq number. > And the `ub` is always created as shared. > > Signed-off-by: Alexandru Ardelean > --- > ubusd_monitor.c | 8 +---

[LEDE-DEV] [PATCH 2/3] ubusd: rename goto label from `error` to `out`

2017-07-05 Thread Alexandru Ardelean
Semantic has changed a bit. Signed-off-by: Alexandru Ardelean --- ubusd_proto.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ubusd_proto.c b/ubusd_proto.c index 441d084..b084b86 100644 --- a/ubusd_proto.c +++ b/ubusd_proto.c @@ -345,22 +345,22 @@ static int ubus

[LEDE-DEV] [PATCH 1/3] ubusd: don't free messages in ubus_send_msg() anymore

2017-07-05 Thread Alexandru Ardelean
This makes it clear that `ubus_msg_send()` is only about sending and queue-ing messages, and has nothing to do with free-ing. It can be a bit misleading/confusing when trying to go through the code and make assumptions about whether a buffer is free'd in ubus_send_msg(), or is free'd outside. In

[LEDE-DEV] [PATCH 3/3] ubusd_monitor: alloc & free the buffer outside of the loop

2017-07-05 Thread Alexandru Ardelean
Should save a few cycles, since the data that's being changed is only the seq number. And the `ub` is always created as shared. Signed-off-by: Alexandru Ardelean --- ubusd_monitor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ubusd_monitor.c b/ubusd_monitor.c inde

[LEDE-DEV] [PATCH ubox] Fix logread starvation

2017-07-05 Thread Ron Brash
Hello all, Here is a repost of the previous concatonated patch. This patch contains the fix we needed to stop the logger from silently starving after a number of logs were generated. It was around the 16K mark when the daemons would stop writing to the /var/log/messages file, yet still remain al

[LEDE-DEV] [PATCH ubox] Add logd priority filtering option

2017-07-05 Thread Ron Brash
Hello all, Here is a repost of the previous patch split into a single one. This patch adds the logger priority filtering needed by one of our clients. For example, they who remain unnamed, are running a really stripped down system that wants to parse logs at the logger level. They have some code

Re: [LEDE-DEV] mt7621 cpu stalls - need help testing

2017-07-05 Thread Jaap Buurman
Dear all, I just had time to test it myself and I can confirm that SQM cake is still crashing the router. Hopefully we do have a nice lead now where to look for the issue. If any more testing is needed in the future, please let me know. Thank you very much again for your time and effort, John! Ki

[LEDE-DEV] Help me understand ubus extensions via C api

2017-07-05 Thread Carlito Nueno
Hi all, I want to customize a small feature in how hostapd responds to probe request and I was looking at https://github.com/lede-project/source/blob/master/package/network/services/hostapd/src/src/ap/ubus.c Please help me understand how it works? for example when I call `ubus call hostapd.wlan0-

Re: [LEDE-DEV] [BUG] [lantiq] xrx200 network driver sleeping with spinlock held

2017-07-05 Thread John Crispin
On 03/07/17 18:52, Andrea Merello wrote: Due to some OT reasons I'm compiling LEDE kernel (4.9.31) with several debug checks enabled, and I'm using it on a Lantiq xrx200 board (fritzbox 3370). I've hit a bug (among another one) in lantiq_xrx200.c network driver: in the xrx200_close() function

Re: [LEDE-DEV] Help me understand ubus extensions via C api

2017-07-05 Thread Alexandru Ardelean
On Thu, Jul 6, 2017 at 4:31 AM, Carlito Nueno wrote: > Hi all, > > I want to customize a small feature in how hostapd responds to probe > request and I was looking at > https://github.com/lede-project/source/blob/master/package/network/services/hostapd/src/src/ap/ubus.c > > Please help me understa