Re: [LEDE-DEV] [PATCH] brcm63xx: fix internal phy registers

2016-12-18 Thread dani
The defines were totally correct, what's wrong are the registers in the interrupt function from bcm-phy-lib. I just replaced the defines just to reflect the similiarities with the "Broadcom PHY driver" from where the interrupt function was taken. It eventually could facilitate the work if a furthe

Re: [LEDE-DEV] [PATCH] ubox: Replace strtok with strsep

2016-12-18 Thread Felix Fietkau
On 2016-12-18 02:22, Rosen Penev wrote: > Thread safe replacement. > > Signed-off by: Rosen Penev For ubox this change isn't really necessary. There's no thread safety issues, or issues with use of strtok by callers. - Felix ___ Lede-dev mailing list

Re: [LEDE-DEV] [PATCH] brcm63xx: fix internal phy registers

2016-12-18 Thread Jonas Gorski
Hi, On 18 December 2016 at 02:19, Daniel Gonzalez Cabanelas wrote: > The internal phy is using wrong registers for the config interrupt function, > causing incorrect behavior when detecting the link activity. Fix it. > > We cannot use the bcm_phy_config_intr function from the bcm-phy-lib.c > beca

[LEDE-DEV] [PATCH v2] brcm63xx: fix internal net phy interrupt config

2016-12-18 Thread Daniel Gonzalez Cabanelas
The internal phy is using wrong registers for the config interrupt function, causing incorrect behavior when detecting the link activity. Fix it. We cannot use the bcm_phy_config_intr function from the bcm-phy-lib.c because it uses different registers from brcm63xx. The old function was right, so

Re: [LEDE-DEV] [PATCH] brcm63xx: fix internal phy registers

2016-12-18 Thread Daniel
Ok, patch v2 sent, only with the interrupt bug fix, and without renaming all registers. > Also this change should go upstream. If you don't want to handle it, I > can do as well. Yes, please make the upstream work. Regards 2016-12-18 12:54 GMT+01:00 Jonas Gorski : > Hi, > > On 18 December 2016

[LEDE-DEV] [PATCH] Added support for the TP-Link WA855RE V1

2016-12-18 Thread Federico Cappon
The device it's similar to the WR841N/ND v9 but without the internal switch. For install Lede, after soldering the serial, follow the istruction for the WR841N/ND v9 Signed-off-by: Federico Cappon --- target/linux/ar71xx/base-files/etc/board.d/01_leds | 3 + .../linux/ar71xx/base-files/etc/bo

Re: [LEDE-DEV] [PATCH] ubox: Replace strtok with strsep

2016-12-18 Thread Arjen de Korte
Citeren Felix Fietkau : On 2016-12-18 02:22, Rosen Penev wrote: Thread safe replacement. Signed-off by: Rosen Penev For ubox this change isn't really necessary. There's no thread safety issues, or issues with use of strtok by callers. I have my doubts about using strsep() on dynamically al

[LEDE-DEV] [PATCH] ar71xx: Added support for the TP-Link WA855RE V1

2016-12-18 Thread Federico Cappon
The device it's similar to the WR841N/ND v9 but without the internal switch. For install Lede, after soldering the serial, follow the istruction for the WR841N/ND v9 Signed-off-by: Federico Cappon --- target/linux/ar71xx/base-files/etc/board.d/01_leds | 3 + .../linux/ar71xx/base-files/etc/bo

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

2016-12-18 Thread Arjen de Korte
Citeren John Crispin : On 16/12/2016 11:10, Felix Fietkau wrote: On 2016-12-16 10:58, John Crispin wrote: On 14/12/2016 06:43, Rosen Penev wrote: strsep is re-entrant whereas strtok not necessarily so. Signed-off by: Rosen Penev --- ulog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [LEDE-DEV] [PATCH] ar71xx: Added support for the TP-Link WA855RE V1

2016-12-18 Thread Matthias Schiffer
On 12/18/2016 03:35 PM, Federico Cappon wrote: > The device it's similar to the WR841N/ND v9 but without the internal switch. > For install Lede, after soldering the serial, follow the istruction for the > WR841N/ND v9 > > Signed-off-by: Federico Cappon > --- > target/linux/ar71xx/base-files/et

Re: [LEDE-DEV] [PATCH v2] brcm63xx: fix internal net phy interrupt config

2016-12-18 Thread Florian Fainelli
On 12/18/2016 05:11 AM, Daniel Gonzalez Cabanelas wrote: > The internal phy is using wrong registers for the config interrupt function, > causing incorrect behavior when detecting the link activity. Fix it. > > We cannot use the bcm_phy_config_intr function from the bcm-phy-lib.c > because it u

Re: [LEDE-DEV] [PATCH v2] package-ipkg: Do not fail build without base-files

2016-12-18 Thread Florian Fainelli
On 12/09/2016 04:04 PM, Florian Fainelli wrote: > If the base-files package is not selected, we will fail executing the > very first postinst script: > > make[3]: Leaving directory `/local/users/fainelli/openwrt/trunk' > cp -fpR > /local/users/fainelli/openwrt/trunk/build_dir/target-arm_xscale_m

Re: [LEDE-DEV] [PATCH v2] brcm63xx: fix internal net phy interrupt config

2016-12-18 Thread Daniel
Yes, better if I included that info. I was lazy to look for the specific commit which caused the breakage. If Jonas makes the upstream, it can be made there. Anyway I can resend again the patch if needed. Regards 2016-12-18 19:28 GMT+01:00 Florian Fainelli : > > > On 12/18/2016 05:11 AM, Daniel G

Re: [LEDE-DEV] [PATCH] ppp: add the peerdns option to ppp interface protocol

2016-12-18 Thread Weedy
On 14 December 2016 at 09:35, Gianluca Anzolin wrote: > On Wed, Dec 14, 2016 at 02:31:48PM +0100, Gianluca Anzolin wrote: >> Add the peerdns option to the ppp interface protocol in the network >> configuration file. > > Hi, > > please ignore this patch, I looked at the git log and saw that the > o

Re: [LEDE-DEV] uqmi: Change returned value to QMI_CMD_REQUEST for 'sync' command.

2016-12-18 Thread Nikolay Ledovskikh
2016-12-16 14:35 GMT+03:00 Nickolay Ledovskikh : > QMI_CMD_DONE is not working properly with 'sync' command. > We must use QMI_CMD_REQUEST. Ping. -- Best regards, Nikolay Ledovskikh. ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.

Re: [LEDE-DEV] [PATCH] libubox: replace strtok with strsep

2016-12-18 Thread John Crispin
On 18/12/2016 17:29, Arjen de Korte wrote: > Citeren John Crispin : > >> On 16/12/2016 11:10, Felix Fietkau wrote: >>> On 2016-12-16 10:58, John Crispin wrote: On 14/12/2016 06:43, Rosen Penev wrote: > strsep is re-entrant whereas strtok not necessarily so. > > Signed-

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

2016-12-18 Thread Nikolay Ledovskikh
> It's useful when using multiple usb devices that should be bound to > certain usb ports. Symlinks are created by hotplug handlers. Ping. ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

2016-12-18 Thread John Crispin
On 19/12/2016 08:20, Nikolay Ledovskikh wrote: >> It's useful when using multiple usb devices that should be bound to >> certain usb ports. Symlinks are created by hotplug handlers. > > Ping. > pong ... "weekend, that thing where people rest" ___ L

Re: [LEDE-DEV] [PATCH] kernel: add KERNEL_DEVMEM and KERNEL_DEVKMEM

2016-12-18 Thread John Crispin
On 17/12/2016 15:04, Hauke Mehrtens wrote: > These options are needed to create /dev/mem or /dev/kmem . > /dev/mem is needed by the io tool to access raw hardware memory, which > is helpful when debugging and developing drivers. > > Signed-off-by: Hauke Mehrtens Acked-by: John Crispin > ---

Re: [LEDE-DEV] [LEDE-DEV v3] Add support of using device symlinks.

2016-12-18 Thread Nikolay Ledovskikh
> pong ... > > "weekend, that thing where people rest" OK. I'll wait for that wonderful moment -- Best regards, Nikolay Ledovskikh. ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev