Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-23 Thread Philip Prindeville
To make things go a little faster, I’ve put up a PR on github: https://github.com/openwrt/packages/pull/3894 > On Jan 18, 2017, at 12:39 AM, John Crispin wrote: > > Hi, > > although the content of the patch looks good the format is incorrect. > you really want to generate the patch using git

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-18 Thread Philip Prindeville
You can also add: Reviewed-by: Philip Prindeville regarding the unix-stream() vs. unix-dgram(), here’s a bug from Debian (which also uses syslog-ng): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=384802 > On Jan 18, 2017, at 12:39 AM, John Crispin wrote: > > Hi, > > although the conte

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-18 Thread Philip Prindeville
I was going to submit a fix myself but while you’re making changes... One thing I did notice is that MUSL does openlog() as a DGRAM socket, but syslog-ng currently opens a STREAM socket (in files/syslog-ng.conf). Can you please change the unix-stream() to unix-gram() instead? Thanks. > On J

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-17 Thread John Crispin
Hi, although the content of the patch looks good the format is incorrect. you really want to generate the patch using git and then use git format-patch/send-email to export and mail it. we cannot merge it in this format i am afraid. please also make sure to add a Signed-off-by line John

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-17 Thread Milan Kočvara
Hello, Sorry for miss and late. Changes bellow. I do not found any other "depracated" function. One question about klogd and syslog-ng kernel messagess. On Linux, the klogd daemon can be used in addition to syslog-ng to read kernel messages and forward them to syslog-ng. klogd used to preproc

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-17 Thread Philip Prindeville
Actually, I take that back. Milan, can you please update the top line of files/syslog-ng.conf also? It needs to read “3.9” instead (assuming there aren’t any syntactic constructs in that file that are now deprecated from 3.8 to 3.9… if there were, the file would need to be updated as well… lik

Re: [LEDE-DEV] Syslog-ng Makefile typo

2017-01-16 Thread Philip Prindeville
Looks good to me. > On Jan 16, 2017, at 4:24 AM, Milan Kočvara wrote: > > Hello. > I found typo in syslog-ng makefile. > > I've upgraded to the newest version and I've made correction of the typo. > Patch bellow. > > Sorry for bad format of everything. I did it never :) > > --- Makefile-ori