Re: [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

2016-06-21 Thread Matthias Schiffer
On 06/21/2016 12:32 PM, Jo-Philipp Wich wrote: > Hi, > > first of all, thanks for putting work into that - I like the changes in > general. Have a few comments inline below. > > ~ Jo > [...] >> diff --git a/lua/uloop.c b/lua/uloop.c >> index 782b5a5..db89e72 100644 >> --- a/lua/uloop.c >> +++ b/

Re: [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

2016-06-21 Thread Matthias Schiffer
On 06/21/2016 12:32 PM, Jo-Philipp Wich wrote: > Hi, > > first of all, thanks for putting work into that - I like the changes in > general. Have a few comments inline below. > > ~ Jo > >> Consistently handle allocation failures. Some functions are changed to >> return bool instead of void to all

Re: [LEDE-DEV] [PATCH libubox 1/3] Fix various memory management issues

2016-06-21 Thread Jo-Philipp Wich
Hi, first of all, thanks for putting work into that - I like the changes in general. Have a few comments inline below. ~ Jo > Consistently handle allocation failures. Some functions are changed to > return bool instead of void to allow returning an error. > > Also fix a buffer size miscalculati