* Felix Fietkau [02.10.2016 17:48]:
> >> +[ -n "$TOPDIR" ] && cd "$TOPDIR" || exit
> >>
> > these two are plain broken, as the script would just exit if TOPDIR is
> > empty. you need to use braces.
> I think a better approach would be to write a wrapper for cd, making it
> easier to read and rev
Hi Jan-Tarek,
Am Sat, 1 Oct 2016 21:37:14 +0200
schrieb Jan-Tarek Butt :
> > I am not sure, if this script is supposed to break on every missing libdir
> > (I
> > do not know the context). Thus maybe " && " would be better instead ";"?
> > This would prevent unwanted directories (e.g. the curre
On 10/01/2016 09:43 PM, Jan-Tarek Butt wrote:
> Hi,
>
> On 10/01/16 10:54, Felix Fietkau wrote:
>> On 2016-10-01 09:44, Oswald Buddenhagen wrote:
>>> On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote:
diff --git a/scripts/get_source_date_epoch.sh
b/scripts/get_source_date_
Hi,
On 10/01/16 10:54, Felix Fietkau wrote:
> On 2016-10-01 09:44, Oswald Buddenhagen wrote:
>> On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote:
>>> diff --git a/scripts/get_source_date_epoch.sh
>>> b/scripts/get_source_date_epoch.sh
>>> -[ -n "$TOPDIR" ] && cd "$TOPDIR"
>>> +[ -n
On 10/01/16 00:05, Lars Kruse wrote:
> Hi,
>
>
> Am Fri, 30 Sep 2016 22:02:19 +0200
> schrieb Jan-Tarek Butt :
>
>
>> diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
>> index 5cae341..9efcac5 100755
>> --- a/scripts/clean-package.sh
>> +++ b/scripts/clean-package.sh
>> @@ -8,
On 2016-10-01 09:44, Oswald Buddenhagen wrote:
> On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote:
>> diff --git a/scripts/get_source_date_epoch.sh
>> b/scripts/get_source_date_epoch.sh
>> -[ -n "$TOPDIR" ] && cd "$TOPDIR"
>> +[ -n "$TOPDIR" ] && cd "$TOPDIR" || exit
>> diff --git a/
On Sat, Oct 01, 2016 at 12:05:16AM +0200, Lars Kruse wrote:
> Am Fri, 30 Sep 2016 22:02:19 +0200 schrieb Jan-Tarek Butt :
> > - libdirs="$libdirs $(cd "$libdir"; pwd)/"
> > + libdirs="$libdirs $(cd "$libdir" || exit;
> > pwd)/" fi
>
> I am not su
On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote:
> diff --git a/scripts/get_source_date_epoch.sh
> b/scripts/get_source_date_epoch.sh
> -[ -n "$TOPDIR" ] && cd "$TOPDIR"
> +[ -n "$TOPDIR" ] && cd "$TOPDIR" || exit
> diff --git a/scripts/getver.sh b/scripts/getver.sh
> -[ -n "$TOPDIR
Hi,
Am Fri, 30 Sep 2016 22:02:19 +0200
schrieb Jan-Tarek Butt :
> diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
> index 5cae341..9efcac5 100755
> --- a/scripts/clean-package.sh
> +++ b/scripts/clean-package.sh
> @@ -8,14 +8,14 @@
> exit 1
> }
> cat "$1" | (
> - cd
---
scripts/clean-package.sh | 4 ++--
scripts/deptest.sh | 4 ++--
scripts/ext-toolchain.sh | 12 ++--
scripts/get_source_date_epoch.sh | 2 +-
scripts/getver.sh| 2 +-
scripts/patch-specs.sh | 2 +-
scripts/sysupgrade-tar.sh
10 matches
Mail list logo
