Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-10-02 Thread Lars Kruse
Hello Oswald, Am Sat, 1 Oct 2016 09:35:47 +0200 schrieb Oswald Buddenhagen : > On Fri, Sep 30, 2016 at 11:50:09PM +0200, Lars Kruse wrote: > > Am Fri, 30 Sep 2016 22:02:15 +0200 schrieb Jan-Tarek Butt : > > > [...] > > > > Just out of curiosity: do you know, what could be the purpose of t

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-10-01 Thread Oswald Buddenhagen
On Fri, Sep 30, 2016 at 11:50:09PM +0200, Lars Kruse wrote: > Am Fri, 30 Sep 2016 22:02:15 +0200 schrieb Jan-Tarek Butt : > > - for pattern in $(eval echo $spec); do > > - find $libdirs -name "$pattern.so*" | sort -u > > + for pattern in $(eval echo "$spec"); d

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Jan-Tarek Butt
On 10/01/16 01:49, Lars Kruse wrote: > Hi Jan-Tarek, > > > Am Sat, 1 Oct 2016 01:27:24 +0200 > schrieb Jan-Tarek Butt : > > >>> Is there a reason for not adding quotes for CE_VERSION and FILE_NUM? >> >> bacause there just nummeric. > > personally I would add quotes wherever possible. They

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, Am Sat, 1 Oct 2016 01:27:24 +0200 schrieb Jan-Tarek Butt : > > Is there a reason for not adding quotes for CE_VERSION and FILE_NUM? > > bacause there just nummeric. personally I would add quotes wherever possible. They would not hurt here. Whenever I will read the above line

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Jan-Tarek Butt
Hi Lars, On 09/30/16 23:50, Lars Kruse wrote: > Hi Jan-Tarek, > > first of all: I am very happy to see your patches! Thanks :) > Whenever I took a look at some shell scripts in openwrt, I felt the strong > urge > to change many of the things you went out to fix. But until now I was always > st

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Lars Kruse
Hi Jan-Tarek, first of all: I am very happy to see your patches! Whenever I took a look at some shell scripts in openwrt, I felt the strong urge to change many of the things you went out to fix. But until now I was always stopped by the sheer amount of changes necessary. Thank you! Am Fri, 30 Se

[LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

2016-09-30 Thread Jan-Tarek Butt
--- scripts/arm-magic.sh | 12 ++-- scripts/clean-package.sh | 2 +- scripts/combined-ext-image.sh| 10 +- scripts/combined-image.sh| 2 +- scripts/deptest.sh | 12 ++-- scripts/ext-toolchain.sh | 16