* Jan-Tarek Butt [02.10.2016 17:48]:
> I did some bugfixing and code quality improvement for
> all shell scrips inside the dir ./scripts.
thanks for the work, but for now i'am against merging it:
we discussed all (and more) of these changes during battlemesh
and we agreed to *first* have an auto
Hi Alberto,
On 09/30/16 23:02, Alberto Bursi wrote:
> I'm suspecting he did use shellcheck.net (or its local version,
> shellcheck) to find the errors.
>
> That's a great tool to find all dumb mistakes and bad practices in scripts.
>
> It's also opensource:
>
> https://github.com/koalaman/shel
I'm suspecting he did use shellcheck.net (or its local version,
shellcheck) to find the errors.
That's a great tool to find all dumb mistakes and bad practices in scripts.
It's also opensource:
https://github.com/koalaman/shellcheck
-Alberto
On 09/30/2016 10:19 PM, John Crispin wrote:
>
> On
On 09/30/16 22:19, John Crispin wrote:
> On 30/09/2016 22:02, Jan-Tarek Butt wrote:
>> Hi,
>>
>> I did some bugfixing and code quality improvement for
>> all shell scrips inside the dir ./scripts.
>>
>> cheers
>> Tarek
>
>
> Hi Tarek,
>
> did you manually generate these or did you use some sem
On 30/09/2016 22:02, Jan-Tarek Butt wrote:
> Hi,
>
> I did some bugfixing and code quality improvement for
> all shell scrips inside the dir ./scripts.
>
> cheers
> Tarek
Hi Tarek,
did you manually generate these or did you use some semantic patching tools.
John
> Jan-Tarek Butt (1
Hi,
I did some bugfixing and code quality improvement for
all shell scrips inside the dir ./scripts.
cheers
Tarek
Jan-Tarek Butt (15):
Double quote to prevent globbing and word splitting
code style: remove whitespaces on end of lines
Add and fix a shebang
$/${} is unnecessary on arithmet
