Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Etienne Champetier
2016-06-23 17:05 GMT+02:00 Jo-Philipp Wich : > Hi. > >> why put multiple possibly unrelated functions under one option? > > To have a global "write to flash is okay" option instead of needing to > change different options with different semantics in different places. if it's disabled by default i

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Etienne Champetier
Hi Daniel, 2016-06-23 17:19 GMT+02:00 Daniel Gimpelevich : > On Thu, 2016-06-16 at 09:38 +, Etienne CHAMPETIER wrote: >> +SEED=/etc/urandom.seed >> + >> +error_exit() { >> +logger -t urandom_seed "$1" >> +exit 1 >> +} >> + >> +save() { >> +touch $SEED.tmp || error_exit "touch faile

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Daniel Gimpelevich
On Thu, 2016-06-16 at 09:38 +, Etienne CHAMPETIER wrote: > +SEED=/etc/urandom.seed > + > +error_exit() { > +logger -t urandom_seed "$1" > +exit 1 > +} > + > +save() { > +touch $SEED.tmp || error_exit "touch failed" > +chown root:root $SEED.tmp || error_exit "chown failed" > +

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Jo-Philipp Wich
Hi. > why put multiple possibly unrelated functions under one option? To have a global "write to flash is okay" option instead of needing to change different options with different semantics in different places. For example if I want to make the lease file persistent, I would change the path in

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Etienne Champetier
2016-06-23 16:08 GMT+02:00 Jo-Philipp Wich : > Hi, > > if we plan to attach multiple functions to the option (e.g. persistent > lease file) then it would probably make sense to give it a generic name, > e.g. > > "option persist 0/1" > > or > > "option save_state 0/1" why put multiple possibly un

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Jo-Philipp Wich
Hi, if we plan to attach multiple functions to the option (e.g. persistent lease file) then it would probably make sense to give it a generic name, e.g. "option persist 0/1" or "option save_state 0/1" ~ Jo ___ Lede-dev mailing list Lede-dev@lists.

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-23 Thread Etienne Champetier
Hi all, 2016-06-22 10:12 GMT+02:00 Kevin Darbyshire-Bryant : > > > On 22/06/16 08:50, John Crispin wrote: >> >> > >> >> write_urandom_seed_on_boot was a placeholder for what the option should >> be named as i could not think of a good one ;) please try to find a >> shorter one >> >> John

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-22 Thread Kevin Darbyshire-Bryant
On 22/06/16 08:50, John Crispin wrote: write_urandom_seed_on_boot was a placeholder for what the option should be named as i could not think of a good one ;) please try to find a shorter one John May I offer "preserveurandomseed" or 'saveurandom' as some 'random' ideas :-) Kevin

Re: [LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-22 Thread John Crispin
On 16/06/2016 11:38, Etienne CHAMPETIER wrote: > This commit: > 1) seed /dev/urandom with a saved seed as early as possible >(see /lib/preinit/81_urandom_seed) > 2) save a new seed if system.@system[0].write_urandom_seed_on_boot == 1 >or if none exists. We use getrandom() so we are sure /

[LEDE-DEV] [PATCH v4] base-files: seed /dev/urandom

2016-06-16 Thread Etienne CHAMPETIER
This commit: 1) seed /dev/urandom with a saved seed as early as possible (see /lib/preinit/81_urandom_seed) 2) save a new seed if system.@system[0].write_urandom_seed_on_boot == 1 or if none exists. We use getrandom() so we are sure /dev/urandom pool is initialized (see /etc/init.d/urandom