Re: [LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

2016-10-06 Thread Oswald Buddenhagen
this commit message is cryptic; i had to read the patch to understand what you mean. there seems to be a pattern. ;) also, technically speaking, you're not _fixing_ the indentation, as it was canonical. you're using a less known shell feature to _improve_ it. (fwiw, i dislike that the syntax _requ

[LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- package/boot/uboot-envtools/files/uboot-envtools.sh | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/package/boot/uboot-envtools/files/uboot-envtools.sh b/package/boot/uboot-envtools/files/uboot-envtools.sh index e21b283