Re: [LEDE-DEV] [PATCH v2] ct-bugcheck: fix globbing, word splitting and formatting

2016-10-05 Thread Jan-Tarek Butt
Hi John, > On 05/10/2016 15:37, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> { cmd1; cmd2; } >> file instead of individual redirects. >> simplifying syntax >> >> Signed-off-by: Jan-Tarek Butt > thanks for the fixes, did you runtime test this patch to make sure

Re: [LEDE-DEV] [PATCH v2] ct-bugcheck: fix globbing, word splitting and formatting

2016-10-05 Thread John Crispin
On 05/10/2016 15:37, Jan-Tarek Butt wrote: > Double quote to prevent globbing and word splitting. > { cmd1; cmd2; } >> file instead of individual redirects. > simplifying syntax > > Signed-off-by: Jan-Tarek Butt Hi, thanks for the fixes, did you runtime test this patch to make sure there are

[LEDE-DEV] [PATCH v2] ct-bugcheck: fix globbing, word splitting and formatting

2016-10-05 Thread Jan-Tarek Butt
Double quote to prevent globbing and word splitting. { cmd1; cmd2; } >> file instead of individual redirects. simplifying syntax Signed-off-by: Jan-Tarek Butt --- package/utils/ct-bugcheck/src/bugcheck.sh | 177 ++ 1 file changed, 83 insertions(+), 94 deletions(-) di