Re: [LEDE-DEV] [PATCH procd 7/7] jail: don't CLONE_NEWUTS if we don't change hostname

2016-05-30 Thread John Crispin
On 30/05/2016 11:59, Etienne Champetier wrote: > Hi John, > > 2016-05-30 9:33 GMT+02:00 John Crispin : >> >> >> Hi Etienne, >> >> why dont we want to do that ? > > If you modify the hostname of the router you might want to propagate > it into the jail, it depends > > Please don't merge this pa

Re: [LEDE-DEV] [PATCH procd 7/7] jail: don't CLONE_NEWUTS if we don't change hostname

2016-05-30 Thread Etienne Champetier
Hi John, 2016-05-30 9:33 GMT+02:00 John Crispin : > > > Hi Etienne, > > why dont we want to do that ? If you modify the hostname of the router you might want to propagate it into the jail, it depends Please don't merge this patch, i will improve it a bit: no -h => no CLONE_NEWUTS -h => CLONE_N

Re: [LEDE-DEV] [PATCH procd 7/7] jail: don't CLONE_NEWUTS if we don't change hostname

2016-05-30 Thread John Crispin
Hi Etienne, why dont we want to do that ? John On 30/05/2016 01:39, Etienne CHAMPETIER wrote: > Signed-off-by: Etienne CHAMPETIER > --- > jail/jail.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/jail/jail.c b/jail/jail.c > index e425254..926e42c 1

[LEDE-DEV] [PATCH procd 7/7] jail: don't CLONE_NEWUTS if we don't change hostname

2016-05-29 Thread Etienne CHAMPETIER
Signed-off-by: Etienne CHAMPETIER --- jail/jail.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/jail/jail.c b/jail/jail.c index e425254..926e42c 100644 --- a/jail/jail.c +++ b/jail/jail.c @@ -386,9 +386,10 @@ int main(int argc, char **argv) uloop_init();