Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-05-03 Thread Pierre Lebleu
2017-05-03 3:54 GMT+02:00 Eric Luehrsen : > > > On 05/02/2017 05:36 PM, Paul Oranje wrote: >> Assignment within a condition is easily read by (dyslectic) humans as a test >> for equality (==) and is for that reason als better avoided. >> Paul >> >>> Op 2 mei 2017, om 18:43 heeft Philip Prindeville

Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-05-02 Thread Eric Luehrsen
On 05/02/2017 05:36 PM, Paul Oranje wrote: > Assignment within a condition is easily read by (dyslectic) humans as a test > for equality (==) and is for that reason als better avoided. > Paul > >> Op 2 mei 2017, om 18:43 heeft Philip Prindeville >> het volgende geschreven: >> >> >>> On May 2,

Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-05-02 Thread Paul Oranje
Assignment within a condition is easily read by (dyslectic) humans as a test for equality (==) and is for that reason als better avoided. Paul > Op 2 mei 2017, om 18:43 heeft Philip Prindeville > het volgende geschreven: > > >> On May 2, 2017, at 6:15 AM, Pierre Lebleu wrote: >> >> Hi Phili

Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-05-02 Thread Philip Prindeville
> On May 2, 2017, at 6:15 AM, Pierre Lebleu wrote: > > Hi Philip, > > 2017-04-29 3:11 GMT+02:00 Philip Prindeville > : > Inline… > > > [snip] > > + if (!(ipset = fw3_alloc_ipset(state))) > > > Minor nit… Assignments inside of conditionals are a bear to step through in > a deb

Re: [LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-04-28 Thread Philip Prindeville
Inline… > On Apr 20, 2017, at 10:05 AM, Pierre Lebleu wrote: > > It gives the ability to create ipset rules via procd > services and netifd interface firewall data. > > Signed-off-by: Pierre Lebleu > --- > ipsets.c | 83 +++--- > ipsets

[LEDE-DEV] [PATCH 5/7] firewall3: add UBUS support for ipset sections

2017-04-20 Thread Pierre Lebleu
It gives the ability to create ipset rules via procd services and netifd interface firewall data. Signed-off-by: Pierre Lebleu --- ipsets.c | 83 +++--- ipsets.h | 11 + main.c |2 +- 3 files changed, 65 insertions(+), 31