Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-12-07 Thread Ted Hess
Ack from me for PKG_HASH=none. Much easier to use. /ted -Original Message- From: Jo-Philipp Wich Sent: Thursday, December 07, 2017 9:56 AM To: lede-dev@lists.infradead.org Subject: Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH Hi Baptiste, we've

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-12-07 Thread Stijn Tintel
On 07-12-17 15:56, Jo-Philipp Wich wrote: > Hi Baptiste, > > we've been discussing this patch again on IRC today and I came up with > an alternate suggestion that does not require a new variable. > > -- 8< -- > diff --git a/scripts/download.pl b/scripts/download.pl > index 775408934a..ad9c480c67 10

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-12-07 Thread Jo-Philipp Wich
Hi Baptiste, we've been discussing this patch again on IRC today and I came up with an alternate suggestion that does not require a new variable. -- 8< -- diff --git a/scripts/download.pl b/scripts/download.pl index 775408934a..ad9c480c67 100755 --- a/scripts/download.pl +++ b/scripts/download.pl

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-11-29 Thread Stijn Tintel
On 08-11-17 12:14, Baptiste Jonglez wrote: > Hi Stijn, > > What is your opinion on this patch? There has been a bit of feedback, but > you were the one requesting the change in the first place :) It seems most feedback simply ignores the part where b30ba14e actually broke existing functionality. I

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-11-08 Thread Baptiste Jonglez
Hi Stijn, What is your opinion on this patch? There has been a bit of feedback, but you were the one requesting the change in the first place :) Thanks, Baptiste On 26-10-17, Baptiste Jonglez wrote: > When calling a download target, hash verification is now completely > skipped if the SKIPHASH

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-27 Thread Baptiste Jonglez
On 27-10-17, Yousong Zhou wrote: > On 26 October 2017 at 17:50, Baptiste Jonglez wrote: > > When calling a download target, hash verification is now completely > > skipped if the SKIPHASH variable is set. > > > > This allows to easily bump package version: > > > > # Update PKG_VERSION in the p

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-27 Thread Baptiste Jonglez
On 26-10-17, Karl Palsson wrote: > Until/if your new documentation project takes off, please > consider adding this to the "how to package" doc pages. none of > these extra magical parameters are discoverable in any way right > now. Fully agreed, all this is magical enough :) While writing this p

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-26 Thread Yousong Zhou
On 26 October 2017 at 17:50, Baptiste Jonglez wrote: > When calling a download target, hash verification is now completely > skipped if the SKIPHASH variable is set. > > This allows to easily bump package version: > > # Update PKG_VERSION in the package Makefile > $ make package//download

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-26 Thread Andrey Jr. Melnikov
Baptiste Jonglez wrote: > When calling a download target, hash verification is now completely > skipped if the SKIPHASH variable is set. > This allows to easily bump package version: > # Update PKG_VERSION in the package Makefile > $ make package//download SKIPHASH=1 V=s > $ make pac

Re: [LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-26 Thread Karl Palsson
Baptiste Jonglez wrote: > When calling a download target, hash verification is now > completely skipped if the SKIPHASH variable is set. > > This allows to easily bump package version: > > # Update PKG_VERSION in the package Makefile > $ make package//download SKIPHASH=1 V=s > $ mak

[LEDE-DEV] [PATCH 2/2] download.mk: introduce a new variable SKIPHASH

2017-10-26 Thread Baptiste Jonglez
When calling a download target, hash verification is now completely skipped if the SKIPHASH variable is set. This allows to easily bump package version: # Update PKG_VERSION in the package Makefile $ make package//download SKIPHASH=1 V=s $ make package//check FIXUP=1 V=s This will do