Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-28 Thread Chris Blake
John, Sounds good. My only question is around the current RFC for the PC Engines APU2 which has this application defined in the profile for the board. Would that be enough justification to allow this into the LEDE branch, or would it be OK to keep "beep" defined in the profile and just merge this

Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-27 Thread John Crispin
Hi, after some time considering i am against merging this into trunk. there are no direct users and no hardware that wont function without. please submit the package as a PR to the packages feed. John On 19/10/2016 16:59, Chris Blake wrote: > This adds the "beep" binary as a package to L

Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-26 Thread Chris Blake
Hey Rafał, Is this commit still acceptable for merge, or should it be revisited with either a personal copyright to me, or to LEDE? Regards, Chris Blake On Wed, Oct 19, 2016 at 4:36 PM, Rafał Miłecki wrote: > On 19 October 2016 at 16:59, Chris Blake wrote: >> diff --git a/package/utils/beep/Ma

Re: [LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-19 Thread Rafał Miłecki
On 19 October 2016 at 16:59, Chris Blake wrote: > diff --git a/package/utils/beep/Makefile b/package/utils/beep/Makefile > new file mode 100644 > index 000..b9bb4d80 > --- /dev/null > +++ b/package/utils/beep/Makefile > @@ -0,0 +1,50 @@ > +# > +# Copyright (C) 2016 OpenWrt.org > +# > +# This i

[LEDE-DEV] [PATCH 1/1] package/utils: Add beep package

2016-10-19 Thread Chris Blake
This adds the "beep" binary as a package to LEDE. Note that busybox does have a beep option that can be built in, but it is disabled by default on all LEDE targets. This package gives users the option to manually install beep at a later time, or include it as a default for a device profile. This w