Re: [LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread John Crispin
On 18/05/2016 13:35, Daniel Curran-Dickinson wrote: > On 16-05-18 07:31 AM, Conor O'Gorman wrote: >> On 18/05/16 12:21, Jo-Philipp Wich wrote: >>> On 05/18/2016 12:12 PM,l...@daniel.thecshore.com wrote: > Hi John, > > I haven't tested these changes yet, >> Testing would be good befor

Re: [LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread Daniel Curran-Dickinson
On 16-05-18 07:31 AM, Conor O'Gorman wrote: > On 18/05/16 12:21, Jo-Philipp Wich wrote: >> On 05/18/2016 12:12 PM,l...@daniel.thecshore.com wrote: >>> >Hi John, >>> > >>> >I haven't tested these changes yet, > Testing would be good before next submission. The whole point of the [RFC] is that it's

Re: [LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread Daniel Dickinson
On 16-05-18 07:31 AM, Conor O'Gorman wrote: > On 18/05/16 12:21, Jo-Philipp Wich wrote: >> On 05/18/2016 12:12 PM,l...@daniel.thecshore.com wrote: >>> >Hi John, >>> > >>> >I haven't tested these changes yet, > Testing would be good before next submission. My goal was actually to make sure that I

Re: [LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread Conor O'Gorman
On 18/05/16 12:21, Jo-Philipp Wich wrote: On 05/18/2016 12:12 PM,l...@daniel.thecshore.com wrote: >Hi John, > >I haven't tested these changes yet, Testing would be good before next submission. ___ Lede-dev mailing list Lede-dev@lists.infradead.org h

Re: [LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread Jo-Philipp Wich
Hi Daniel, ACK from me once the fs checker swap is fixed. ~ Jo On 05/18/2016 12:12 PM, l...@daniel.thecshore.com wrote: > Hi John, > > I haven't tested these changes yet, but is this what you were looking for > in terms of changes to the patches previously as part of the PRs you > commented on?

[LEDE-DEV] [PATCH 0/4] [RFC] fstools: block.c: Various enhancements

2016-05-18 Thread lede
Hi John, I haven't tested these changes yet, but is this what you were looking for in terms of changes to the patches previously as part of the PRs you commented on? [PATCH 1/4] [RFC] fstools: block.c: Make static string a const char * instead char * [PATCH 2/4] [RFC] fstools: block.c: Add suppo