Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-23 Thread Rafał Miłecki
On 17 February 2017 at 11:42, danrl wrote: > We are trying to make passwords on LEDE a tiny bit more secure by refusing > weak or short (read: less than 6 characters) passwords. > > Please see related discussion over here, where the inconsistencies were > discovered: > https://github.com/openwrt

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Dan Lüdtke
What the... This discussion has become a bit out of hand! My goal was to have consistency at LuCI and CLI. I see how enforcing passwords of a particular kind, as well as enforcing passwords at all, is not an engineering decision. I have no problem with this patch being rejected. So, since we de

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Eric Luehrsen
y. - Eric Original message From: David Lang Date: 2/17/17 07:52 (GMT-05:00) To: Alberto Bursi Cc: lede-dev@lists.infradead.org Subject: Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords On Fri, 17 Feb 2017, Alberto B

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread David Lang
On Fri, 17 Feb 2017, Alberto Bursi wrote: On 02/17/2017 12:52 PM, David Lang wrote: On Fri, 17 Feb 2017, Alberto Bursi wrote: And having no password is a much bigger change than having a short password when you are testing things. It makes a lot of sense to be excercising the password routine

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Petr Štetiar
Alberto Bursi [2017-02-17 12:08:03]: > Btw, for console access (serial or TTL or whatever) there is no login > even if you have set a password afaik. BTW, it's a config option, you can enable it: $ uci set system.@system[0].ttylogin='1' -- ynezz ___

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Alberto Bursi
On 02/17/2017 12:52 PM, David Lang wrote: > On Fri, 17 Feb 2017, Alberto Bursi wrote: > > And having no password is a much bigger change than having a short > password when you are testing things. It makes a lot of sense to be > excercising the password routine when doing tests, and very little >

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Alberto Bursi
On 02/17/2017 12:51 PM, John Crispin wrote: > > > regardless of you liking my use case or not its still a NAK > > John > Who cares, really. I just posted my opinion. -Alberto ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.i

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread John Crispin
On 17/02/2017 12:35, Alberto Bursi wrote: > > > On 02/17/2017 12:26 PM, John Crispin wrote: >> >> >> On 17/02/2017 12:16, Dan Lüdtke wrote: >>> Hi David, >>> >>> thanks for the fast response! >>> On 17 Feb 2017, at 11:54, David Lang wrote: But deciding that you know better than the a

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread David Lang
On Fri, 17 Feb 2017, Alberto Bursi wrote: On 02/17/2017 12:26 PM, John Crispin wrote: On 17/02/2017 12:16, Dan Lüdtke wrote: Hi David, thanks for the fast response! On 17 Feb 2017, at 11:54, David Lang wrote: But deciding that you know better than the admin of the system is not. Not th

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Hannu Nyman
On 17.2.2017 12.42, danrl wrote: We are trying to make passwords on LEDE a tiny bit more secure by refusing weak or short (read: less than 6 characters) passwords. Please see related discussion over here, where the inconsistencies were discovered: https://github.com/openwrt/luci/pull/878 Not

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread David Lang
On Fri, 17 Feb 2017, Dan Lüdtke wrote: Hi David, thanks for the fast response! On 17 Feb 2017, at 11:54, David Lang wrote: But deciding that you know better than the admin of the system is not. Not that I am a fan of telling admins what to do, but do you see any chance that we can get an

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Alberto Bursi
On 02/17/2017 12:26 PM, John Crispin wrote: > > > On 17/02/2017 12:16, Dan Lüdtke wrote: >> Hi David, >> >> thanks for the fast response! >> >>> On 17 Feb 2017, at 11:54, David Lang wrote: >>> But deciding that you know better than the admin of the system is not. >> >> Not that I am a fan of tel

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread John Crispin
On 17/02/2017 12:16, Dan Lüdtke wrote: > Hi David, > > thanks for the fast response! > >> On 17 Feb 2017, at 11:54, David Lang wrote: >> But deciding that you know better than the admin of the system is not. > > Not that I am a fan of telling admins what to do, but do you see any chance > th

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread Dan Lüdtke
Hi David, thanks for the fast response! > On 17 Feb 2017, at 11:54, David Lang wrote: > But deciding that you know better than the admin of the system is not. Not that I am a fan of telling admins what to do, but do you see any chance that we can get an consistent and enforceable approach to

Re: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread David Lang
On Fri, 17 Feb 2017, danrl wrote: Date: Fri, 17 Feb 2017 11:42:14 +0100 From: danrl To: lede-dev@lists.infradead.org Cc: Dan Luedtke Subject: [LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords Hi devs, We are trying to make passwords on LEDE a tiny bit more secure by refusing

[LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread danrl
This patches the busybox passwd source so that even root is not allowed to set a weak (too short) password. This enables us to define a minimum password length that is consistent over graphical interfaces (e.g. LuCI) and CLI. Signed-off-by: Dan Luedtke --- .../utils/busybox/patches/900-prevent-w

[LEDE-DEV] [PATCH] utils/busybox: prevent weak root passwords

2017-02-17 Thread danrl
Hi devs, We are trying to make passwords on LEDE a tiny bit more secure by refusing weak or short (read: less than 6 characters) passwords. Please see related discussion over here, where the inconsistencies were discovered: https://github.com/openwrt/luci/pull/878 Here is what the patch change