Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-17 Thread John Crispin
On 07/11/17 21:24, Rosen Penev wrote: Less verbose Signed-off-by: Rosen Penev --- Hi, this does not fix any bugs and is a pure style change. yeah, it might safe a few bytes but i dont see that as a valid trade-off, sorry ...     John interface.c | 22 -- 1 file

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-12 Thread Eric Luehrsen
On 11/12/2017 09:49 PM, ros...@gmail.com wrote: On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: Citeren Rosen Penev : Less verbose. And uses a GCC extension which makes it less portable. ISO C forbids empty initializer braces [1]. See for yourself by adding the -pedantic flag to your

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-12 Thread rosenp
On Wed, 2017-11-08 at 21:17 +0100, Arjen de Korte wrote: > Citeren Rosen Penev : > > > Less verbose. > > And uses a GCC extension which makes it less portable. ISO C > forbids > empty initializer braces [1]. See for yourself by adding the > -pedantic > flag to your CFLAGS. The correct way to

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Karl Palsson
Rosen Penev wrote: > Less verbose. > > Signed-off-by: Rosen Penev > > v2: some of those memset calls are needed. Also replace { 0 } > with {}. cmon, that's just unnecessary. It's one thing to prefer using gnu {} instead of ISO C {0} but replacing ISO standard C form with a gnu form, just beca

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Arjen de Korte
Citeren Rosen Penev : Less verbose. And uses a GCC extension which makes it less portable. ISO C forbids empty initializer braces [1]. See for yourself by adding the -pedantic flag to your CFLAGS. The correct way to initialize to all-zeros is therefore { 0 }. [1] ISO/IEC 9899:201x, par

[LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Rosen Penev
Less verbose. Signed-off-by: Rosen Penev v2: some of those memset calls are needed. Also replace { 0 } with {}. --- interface.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/interface.c b/interface.c index 7f814d2..deabcbb 100644 --- a/interface.c +++ b/i

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Jo-Philipp Wich
Hi, comments inline. > --- > interface.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/interface.c b/interface.c > index 7f814d2..18dee52 100644 > --- a/interface.c > +++ b/interface.c > @@ -44,7 +44,7 @@ > static int > interface_send_packet4

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Matthias Schiffer
On 11/08/2017 10:57 AM, Zefir Kurtisi wrote: > On 11/07/2017 09:24 PM, Rosen Penev wrote: >> Less verbose >> >> Signed-off-by: Rosen Penev >> --- >> interface.c | 22 -- >> 1 file changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/interface.c b/interface.c >> index 7

Re: [LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-08 Thread Zefir Kurtisi
On 11/07/2017 09:24 PM, Rosen Penev wrote: > Less verbose > > Signed-off-by: Rosen Penev > --- > interface.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/interface.c b/interface.c > index 7f814d2..18dee52 100644 > --- a/interface.c > +++ b/int

[LEDE-DEV] [PATCH] umdns: Replace unnecessary memset calls with {}.

2017-11-07 Thread Rosen Penev
Less verbose Signed-off-by: Rosen Penev --- interface.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/interface.c b/interface.c index 7f814d2..18dee52 100644 --- a/interface.c +++ b/interface.c @@ -44,7 +44,7 @@ static int interface_send_packet4(st