Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-16 Thread Hans Dedecker
On Wed, Jun 15, 2016 at 4:54 PM, Mats Karrman wrote: > > On 2016-06-15 15:16, Felix Fietkau wrote: >> >> On 2016-06-15 15:13, Hans Dedecker wrote: >> On Wed, Jun 15, 2016 at >> 11:58 AM, Felix Fietkau >> > > wrote: >>> On 2016-06-15 11:39, Conor O'Gorman wrote: On 09/06/16 > 03:20, Yousong

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Felix Fietkau
On 2016-06-15 16:54, Mats Karrman wrote: > Ran 118 reboots with this fix without any problem so there is a good > chance that > the latest version of libubox (c2f2c47f3e9a2d709ec82a79f6fadd3124c18781) > finally fixed the issue. > :-) // Mats Pushed out the update to the LEDE tree, thanks for testi

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Mats Karrman
On 2016-06-15 15:16, Felix Fietkau wrote: On 2016-06-15 15:13, Hans Dedecker wrote: >> On Wed, Jun 15, 2016 at 11:58 AM, Felix Fietkau >> wrote: >>> On 2016-06-15 11:39, Conor O'Gorman wrote: On 09/06/16 03:20, Yousong Zhou wrote: > Fix a race condition when do_sigchld, uloop_cancel

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Xinxing Hu
rg > Subject: Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying > sigchld and loop cancel events > Message-ID: <5761530d.6010...@gmail.com> > Content-Type: text/plain; charset=windows-1252; format=flowed > > > On 2016-06-15 13:20, Yousong Zhou wrote: >

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Felix Fietkau
On 2016-06-15 15:13, Hans Dedecker wrote: > On Wed, Jun 15, 2016 at 11:58 AM, Felix Fietkau wrote: >> On 2016-06-15 11:39, Conor O'Gorman wrote: >>> On 09/06/16 03:20, Yousong Zhou wrote: Fix a race condition when do_sigchld, uloop_cancelled were set just before epoll_wait(timeout=-1), r

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Hans Dedecker
On Wed, Jun 15, 2016 at 11:58 AM, Felix Fietkau wrote: > On 2016-06-15 11:39, Conor O'Gorman wrote: >> On 09/06/16 03:20, Yousong Zhou wrote: >>> Fix a race condition when do_sigchld, uloop_cancelled were set just >>> before epoll_wait(timeout=-1), resulting the loop stuck in the syscall >>> witho

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Mats Karrman
On 2016-06-15 13:20, Yousong Zhou wrote: On 15 June 2016 at 17:58, Felix Fietkau wrote: On 2016-06-09 04:20, Yousong Zhou wrote: Fix a race condition when do_sigchld, uloop_cancelled were set just before epoll_wait(timeout=-1), resulting the loop stuck in the syscall without noticing the even

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Yousong Zhou
On 15 June 2016 at 17:58, Felix Fietkau wrote: > On 2016-06-09 04:20, Yousong Zhou wrote: >> Fix a race condition when do_sigchld, uloop_cancelled were set just >> before epoll_wait(timeout=-1), resulting the loop stuck in the syscall >> without noticing the events just happened >> >> Signed-off-b

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Felix Fietkau
On 2016-06-15 11:39, Conor O'Gorman wrote: > On 09/06/16 03:20, Yousong Zhou wrote: >> Fix a race condition when do_sigchld, uloop_cancelled were set just >> before epoll_wait(timeout=-1), resulting the loop stuck in the syscall >> without noticing the events just happened >> >> Signed-off-by: Yous

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Felix Fietkau
On 2016-06-09 04:20, Yousong Zhou wrote: > Fix a race condition when do_sigchld, uloop_cancelled were set just > before epoll_wait(timeout=-1), resulting the loop stuck in the syscall > without noticing the events just happened > > Signed-off-by: Yousong Zhou I found a few bugs and inconsistencie

Re: [LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-15 Thread Conor O'Gorman
On 09/06/16 03:20, Yousong Zhou wrote: Fix a race condition when do_sigchld, uloop_cancelled were set just before epoll_wait(timeout=-1), resulting the loop stuck in the syscall without noticing the events just happened Signed-off-by: Yousong Zhou --- uloop-epoll.c | 2 +- uloop-kqueue.c |

[LEDE-DEV] [PATCH] uloop: use a waker for notifying sigchld and loop cancel events

2016-06-08 Thread Yousong Zhou
Fix a race condition when do_sigchld, uloop_cancelled were set just before epoll_wait(timeout=-1), resulting the loop stuck in the syscall without noticing the events just happened Signed-off-by: Yousong Zhou --- uloop-epoll.c | 2 +- uloop-kqueue.c | 2 +- uloop.c| 65 +++