Re: [LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages (alt.)

2018-05-08 Thread Benjamin Hansmann
Hi, What is the acceptance state of this patch? In patchwork it has the status `superseded'. Does it mean that the issue has been or will be solved by other means? Thanks, Benjamin On Thu, 2018-05-03 at 12:06 +0200, Benjamin Hansmann wrote: > The fixed size array for queuing messages led to di

Re: [LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages

2018-05-03 Thread Benjamin Hansmann
Hi Felix, I understand. I just sent an alternative patch which maintains an independent linked list which I think should circumvent the corruption of the same. This of course introduces some additional memory allocation on the heap. When this shouldn't be an option, what would be your suggestion

[LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages (alt.)

2018-05-03 Thread Benjamin Hansmann
The fixed size array for queuing messages led to discarding messages when it was full, using a linked list instead solves this issue. The motivation was that for a recursive "ubus list" the function ubusd_proto.c:ubusd_handle_lookup() produces more than n messages in one uloop cycle when n objects

Re: [LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages

2018-05-03 Thread Alexandru Ardelean
On Thu, May 3, 2018 at 12:07 PM, Felix Fietkau wrote: > Hi Benjamin, > > On 2018-05-02 22:55, Benjamin Hansmann wrote: >> The fixed size array for queuing messages led to discarding messages >> when it was full, using a linked list instead solves this issue. >> >> Having the list_head link in the

Re: [LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages

2018-05-03 Thread Felix Fietkau
Hi Benjamin, On 2018-05-02 22:55, Benjamin Hansmann wrote: > The fixed size array for queuing messages led to discarding messages > when it was full, using a linked list instead solves this issue. > > Having the list_head link in the ubus_msg_buf itself avoids the > allocation of more memory for

Re: [LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages

2018-05-03 Thread Alexandru Ardelean
On Wed, May 2, 2018 at 11:55 PM, Benjamin Hansmann wrote: > The fixed size array for queuing messages led to discarding messages > when it was full, using a linked list instead solves this issue. > > Having the list_head link in the ubus_msg_buf itself avoids the > allocation of more memory for an

[LEDE-DEV] [PATCH] ubusd: Use linked list for queued messages

2018-05-02 Thread Benjamin Hansmann
The fixed size array for queuing messages led to discarding messages when it was full, using a linked list instead solves this issue. Having the list_head link in the ubus_msg_buf itself avoids the allocation of more memory for an independent list. The motivation was that for a recursive "ubus li