Re: [LEDE-DEV] [PATCH] ramips: add get_port_stats to mt7530 swconfig driver

2016-07-23 Thread John Crispin
On 23/07/2016 23:02, p.wa...@gmx.at wrote: > Hi John, > >> please add macros for the register offsets in the header file and use >> them here. there should be 2 defines for the registers and one for the >> port offset. > > may I then also do this for the existing functions? > (I just copied cod

Re: [LEDE-DEV] [PATCH] ramips: add get_port_stats to mt7530 swconfig driver

2016-07-23 Thread p . wassi
Hi John, > please add macros for the register offsets in the header file and use > them here. there should be 2 defines for the registers and one for the > port offset. may I then also do this for the existing functions? (I just copied code from get_port_link(), which also uses those hard-coded m

Re: [LEDE-DEV] [PATCH] ramips: add get_port_stats to mt7530 swconfig driver

2016-07-23 Thread John Crispin
Hi, comments inline On 23/07/2016 17:01, p.wa...@gmx.at wrote: > From: P.Wassi > > Add get_port_stats function to mt7530 swconfig driver. > Signed-off-by: P.Wassi > --- > If one uses "switch" as a trigger for the LEDs, in order to have > the LEDs blinking when there's traffic, swconfig_leds.c

[LEDE-DEV] [PATCH] ramips: add get_port_stats to mt7530 swconfig driver

2016-07-23 Thread p . wassi
From: P.Wassi Add get_port_stats function to mt7530 swconfig driver. Signed-off-by: P.Wassi --- If one uses "switch" as a trigger for the LEDs, in order to have the LEDs blinking when there's traffic, swconfig_leds.c needs to have a get_port_stats function from the swconfig driver. The function