Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-07-04 Thread Felix Fietkau
On 2016-07-04 08:52, Eduardo Abinader wrote: > Thanks for the feedback, Felix. > > I will submit another patch(es) with the changes you commented. Ok? Sure, thanks. - Felix ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.o

Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-07-03 Thread Eduardo Abinader
@lists.infradead.org Subject: Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup On 2016-07-01 11:50, Eduardo Abinader wrote: > Hi Felix, > > 1) Just set a non-allowed DFS channel for DE, for instance. > 2) Enable wireless; it fails > 3) Change to a valid ch

Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-07-02 Thread Felix Fietkau
On 2016-07-01 11:50, Eduardo Abinader wrote: > Hi Felix, > > 1) Just set a non-allowed DFS channel for DE, for instance. > 2) Enable wireless; it fails > 3) Change to a valid channel; the wdev is not set up. > > There is also a leftover on /etc/init.d/network reload. > I think it should call /

Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-07-01 Thread Eduardo Abinader
Hi Felix, 1) Just set a non-allowed DFS channel for DE, for instance. 2) Enable wireless; it fails 3) Change to a valid channel; the wdev is not set up. There is also a leftover on /etc/init.d/network reload. I think it should call /sbin/wifi instead of /sbin/wifi reload. Eduardo On 01.07.20

Re: [LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-06-30 Thread Felix Fietkau
On 2016-06-30 16:18, Eduardo Abinader wrote: > Ensure wireless device struct is removed, when it fails to be set up, > due to a invalid configuration, hence enabling the wireless dev > to be set up again, when a new valid configuration is set. > > Signed-off-by: Eduardo Abinader > --- > wireless

[LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-06-30 Thread Eduardo Abinader
Ensure wireless device struct is removed, when it fails to be set up, due to a invalid configuration, hence enabling the wireless dev to be set up again, when a new valid configuration is set. Signed-off-by: Eduardo Abinader --- wireless.c | 4 1 file changed, 4 insertions(+) diff --git a/

[LEDE-DEV] [PATCH] netifd: remove wireless device when device fails to setup

2016-06-30 Thread Eduardo Abinader
Ensure wireless device struct is removed, when it fails to be set up, due to a invalid configuration, hence enabling the wireless dev to be set up again, when a new valid configuration is set. Signed-off-by: Eduardo Abinader --- wireless.c | 4 1 file changed, 4 insertions(+) diff --git a/