Re: [LEDE-DEV] [PATCH] netifd: propagate error code on netifd_reload()

2017-03-10 Thread Alexandru Ardelean
On Fri, Mar 10, 2017 at 11:40 AM, Felix Fietkau wrote: > On 2017-03-10 10:38, Alexandru Ardelean wrote: >> The context is that we generate some of the UCI config >> for netifd via scripts/programs. >> >> Every once in a while, there's a goof when doing that >> UCI generation, and netifd prints out

Re: [LEDE-DEV] [PATCH] netifd: propagate error code on netifd_reload()

2017-03-10 Thread Felix Fietkau
On 2017-03-10 10:38, Alexandru Ardelean wrote: > The context is that we generate some of the UCI config > for netifd via scripts/programs. > > Every once in a while, there's a goof when doing that > UCI generation, and netifd prints out the error at > stderr, but returns 0 (success) err-code. > >

[LEDE-DEV] [PATCH] netifd: propagate error code on netifd_reload()

2017-03-10 Thread Alexandru Ardelean
The context is that we generate some of the UCI config for netifd via scripts/programs. Every once in a while, there's a goof when doing that UCI generation, and netifd prints out the error at stderr, but returns 0 (success) err-code. This change will fail the ubus call if UCI config is invalid f