Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-10 Thread Russell Senior
> Bert Vermeulen writes: > The patch made sure the ncursesw library was not selected to save > space, but that library doesn't exist in this distribution at all. This commit message is wrong. -- Russell Senior, President russ...@personaltelco.net _

[LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-10 Thread Bert Vermeulen
The patch made sure the ncursesw library was not selected to save space, but that library doesn't exist in this distribution at all. Signed-off-by: Bert Vermeulen --- package/network/utils/iftop/Makefile | 4 ++-- package/network/utils/iftop/patches/0001-force-ncurses.pa

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-08 Thread Bert Vermeulen
On 05/07/2016 08:11 PM, Russell Senior wrote: > In this particular case, as the author of the patch involved, I would > suggest "if it isn't broken, don't fix it". That is, iftop doesn't > really need ncursesw, the patch lets it use plain ncurses even if > ncursesw is available. I don't see the p

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Russell Senior
> "Bert" == Bert Vermeulen writes: Bert> On 05/07/2016 12:46 PM, Felix Fietkau wrote: >> On 2016-05-07 12:40, Bert Vermeulen wrote: >>> On 05/07/2016 12:01 PM, Felix Fietkau wrote: We should probably just move everything to libncursesw and drop libncurses entirely. >>> >>> Actually

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Bert Vermeulen
On 05/07/2016 12:46 PM, Felix Fietkau wrote: On 2016-05-07 12:40, Bert Vermeulen wrote: On 05/07/2016 12:01 PM, Felix Fietkau wrote: We should probably just move everything to libncursesw and drop libncurses entirely. Actually I'd gotten this wrong: libncursesw is an extra build option to lib

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Felix Fietkau
On 2016-05-07 12:40, Bert Vermeulen wrote: > On 05/07/2016 12:01 PM, Felix Fietkau wrote: >> On 2016-05-07 11:43, Bert Vermeulen wrote: >>> Is there anything else that could pull in libncursesw? >> Packages from feeds sometimes use libncursesw instead of libncurses. I >> just did a size comparison:

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Bert Vermeulen
On 05/07/2016 12:01 PM, Felix Fietkau wrote: On 2016-05-07 11:43, Bert Vermeulen wrote: Is there anything else that could pull in libncursesw? Packages from feeds sometimes use libncursesw instead of libncurses. I just did a size comparison: 110481 libncurses_5.9-3_mipsel_1004kc_dsp.ipk 125871

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Felix Fietkau
On 2016-05-07 11:43, Bert Vermeulen wrote: > On 05/07/2016 07:17 AM, John Crispin wrote: >> >> >> On 05/05/2016 15:16, Bert Vermeulen wrote: >>> The patch made sure the ncursesw library was not selected to save space, >>> but that library doesn't exist in this distribution at all. >> >> are you

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Bert Vermeulen
On 05/07/2016 07:17 AM, John Crispin wrote: > > > On 05/05/2016 15:16, Bert Vermeulen wrote: >> The patch made sure the ncursesw library was not selected to save space, >> but that library doesn't exist in this distribution at all. > > are you sure that ncursesw is not inside any of the feeds ei

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-07 Thread Russell Senior
> "John" == John Crispin writes: > On 05/05/2016 15:16, Bert Vermeulen wrote: >> The patch made sure the ncursesw library was not selected to save >> space, but that library doesn't exist in this distribution at all. > are you sure that ncursesw is not inside any of the feeds either ? Hey,

Re: [LEDE-DEV] [PATCH] iftop: Update to latest version, and drop patch

2016-05-06 Thread John Crispin
On 05/05/2016 15:16, Bert Vermeulen wrote: > The patch made sure the ncursesw library was not selected to save space, > but that library doesn't exist in this distribution at all. are you sure that ncursesw is not inside any of the feeds either ? John > > Signed-off-by: Bert Vermeulen