Re: [LEDE-DEV] [PATCH] ct-bugcheck: fix globbing, word splitting and change formatting

2016-10-15 Thread John Crispin
On 14/10/2016 18:03, Ben Greear wrote: > On 10/14/2016 08:58 AM, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> Use short syntax to enhance reading quallity. > > I disagree that the short syntax helps reading quality, > but if others like it then I guess that ch

Re: [LEDE-DEV] [PATCH] ct-bugcheck: fix globbing, word splitting and change formatting

2016-10-14 Thread Ben Greear
On 10/14/2016 08:58 AM, Jan-Tarek Butt wrote: Double quote to prevent globbing and word splitting. Use short syntax to enhance reading quallity. I disagree that the short syntax helps reading quality, but if others like it then I guess that change is fine with me. Thanks, Ben Signed-off-by:

[LEDE-DEV] [PATCH] ct-bugcheck: fix globbing, word splitting and change formatting

2016-10-14 Thread Jan-Tarek Butt
Double quote to prevent globbing and word splitting. Use short syntax to enhance reading quallity. Signed-off-by: Jan-Tarek Butt --- package/utils/ct-bugcheck/src/bugchecker.sh | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/package/utils/ct-bugcheck/src/bugch