Re: [LEDE-DEV] [PATCH] build: Fix not altering KERNELRELEASE for external kernel

2017-06-18 Thread Florian Fainelli
Le 06/18/17 à 14:44, Daniel Golle a écrit : > Not completely related, but it came to my mind a couple of days ago > and maybe you can share your opinion: > Shouldn't we also be setting CONFIG_LOCALVERSION if *not* using an > external kernel, to indicate that this is *not* a vanilla kernel.org > cod

Re: [LEDE-DEV] [PATCH] build: Fix not altering KERNELRELEASE for external kernel

2017-06-18 Thread Florian Fainelli
Le 06/18/17 à 14:27, Hauke Mehrtens a écrit : > When an external kernel tree is used the version should not get > modified by the LEDE build scripts. This was added by Florian some time > ago. > The commit 0aed054becb21439 ("build: add KERNEL_MAKE and > KERNEL_MAKE_FLAGS variables and move to kerne

Re: [LEDE-DEV] [PATCH] build: Fix not altering KERNELRELEASE for external kernel

2017-06-18 Thread Daniel Golle
Not completely related, but it came to my mind a couple of days ago and maybe you can share your opinion: Shouldn't we also be setting CONFIG_LOCALVERSION if *not* using an external kernel, to indicate that this is *not* a vanilla kernel.org codebase but actually got tons of OpenWrt/LEDE patches on

[LEDE-DEV] [PATCH] build: Fix not altering KERNELRELEASE for external kernel

2017-06-18 Thread Hauke Mehrtens
When an external kernel tree is used the version should not get modified by the LEDE build scripts. This was added by Florian some time ago. The commit 0aed054becb21439 ("build: add KERNEL_MAKE and KERNEL_MAKE_FLAGS variables and move to kernel.mk") breaks this feature introduced in b6746a6ffb73 ("