Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-14 Thread Roman Yeryomin
On 2017-12-12 13:41, John Crispin wrote: On 12/12/17 12:37, Felix Fietkau wrote: On 2017-12-12 11:19, John Crispin wrote: On 02/12/17 00:26, Roman Yeryomin wrote: Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roma

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread John Crispin
On 12/12/17 12:37, Felix Fietkau wrote: On 2017-12-12 11:19, John Crispin wrote: On 02/12/17 00:26, Roman Yeryomin wrote: Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin Hi Roman, The code needs t

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread Felix Fietkau
On 2017-12-12 11:19, John Crispin wrote: > > > On 02/12/17 00:26, Roman Yeryomin wrote: >> Moving a file between tmpfs and other fs is neither >> faster nor safer, thus no point in doing it in two steps. >> >> Signed-off-by: Roman Yeryomin > > Hi Roman, > > The code needs to stay like this. th

Re: [LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-12 Thread John Crispin
On 02/12/17 00:26, Roman Yeryomin wrote: Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin Hi Roman, The code needs to stay like this. the moment you start the command with redirection, the shell wil

[LEDE-DEV] [PATCH] base-files: uci-defaults: do config flush in one shot

2017-12-01 Thread Roman Yeryomin
Moving a file between tmpfs and other fs is neither faster nor safer, thus no point in doing it in two steps. Signed-off-by: Roman Yeryomin --- package/base-files/files/lib/functions/uci-defaults.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/base-files/files/li