Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-24 Thread Сергеев Сергей
Hello. See below: On 24/08/2016 11:12, Сергеев Сергей wrote: Hello. Ok. Leave all as is. But...(comments below): On 13/08/2016 13:04, ad...@yapic.net wrote: From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin)

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-24 Thread John Crispin
On 24/08/2016 11:12, Сергеев Сергей wrote: > Hello. Ok. Leave all as is. But...(comments below): >> >> On 13/08/2016 13:04, ad...@yapic.net wrote: >>> From: Sergey Sergeev >>> >>>scp uls(like this >>> scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) >>> >

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-24 Thread Сергеев Сергей
Hello. Ok. Leave all as is. But...(comments below): On 13/08/2016 13:04, ad...@yapic.net wrote: From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-24 Thread John Crispin
On 13/08/2016 13:04, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:lede...) > > Signed-off-by: Se

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-22 Thread Сергеев Сергей
22.08.2016 09:52, Rafał Miłecki пишет: On 13 August 2016 at 13:04, wrote: From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...)

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-21 Thread Rafał Miłecki
On 13 August 2016 at 13:04, wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:lede...) > > Signed-off-by: Sergey Sergee

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-15 Thread Сергеев Сергей
Hello. From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/lib/

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-15 Thread John Crispin
On 13/08/2016 13:04, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:lede...) > > Signed-off-by: Se

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-13 Thread Сергеев Сергей
Hello. Fixed here: http://patchwork.ozlabs.org/patch/658953/ Please check. On 12/08/2016 16:48, ad...@yapic.net wrote: From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can speci

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-13 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/lib/upgrade/common

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-13 Thread John Crispin
On 12/08/2016 16:48, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:lede...) > > Signed-off-by: Se

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-13 Thread John Crispin
On 12/08/2016 16:54, Сергеев Сергей wrote: > Hello. I made a new version of the patch according to your notes: > http://patchwork.ozlabs.org/patch/658677/ > > I remove the shell redirection to stderr because we need to show a > diagnostic messages (for wget) as well as the certificate accept req

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-12 Thread Сергеев Сергей
Hello. I made a new version of the patch according to your notes: http://patchwork.ozlabs.org/patch/658677/ I remove the shell redirection to stderr because we need to show a diagnostic messages (for wget) as well as the certificate accept request and enter the password messages (for ssh) Bot

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-12 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/lib/upgrade/common

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-12 Thread Сергеев Сергей
Hi. Ansvers inline: From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-11 Thread John Crispin
Hi comments inline On 08/08/2016 13:23, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:lede...) >

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-08 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/lib/upgrade/common

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-06 Thread John Crispin
Hi, small comment inline On 04/08/2016 15:21, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) > is supported too. And you also can specify custom ssh > port(...8.88.6:22110:l

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-08-04 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/lib/upgrade/co

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-27 Thread John Crispin
Hi, sorry for the late reply. i like the idea. however, please move the code into get_image() inside package/base-files/files/lib/upgrade/common.sh where the http/ftp code resides. John On 06/07/2016 15:40, ad...@yapic.net wrote: > From: Sergey Sergeev > > scp uls(like this > scp://ad

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-06 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade | 39 +

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-06 Thread adron
From: Sergey Sergeev scp uls(like this scp://adron@192.168.88.6:lede/lede-ar71xx-mikrotik-NAND-512b-squashfs-sysupgrade.bin) is supported too. And you also can specify custom ssh port(...8.88.6:22110:lede...) Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade | 39 +

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-05 Thread Bastian Bittorf
* ad...@yapic.net [05.07.2016 10:55]: > +wget_if_URL(){ > + local url="$1" > + local url_repl_file="/tmp/sysupgrade-URL.bin" > + > + case "$url" in > + http://*|https://*|ftp://*) break ;; > + *) return 1 ;; please use 'return 0' here, otherwise... > + esa

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability

2016-07-04 Thread Luke McKee
t > To: lede-dev@lists.infradead.org > Cc: Sergey Sergeev > Subject: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability > to use URL as source ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread adron
From: Sergey Sergeev I did not encapsulate the logic in get_image() because too much code (like dd if=...) expects to work with the file instead of url. And use get_image would lead to repeated data reloads from url. Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade |

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread adron
From: Sergey Sergeev I did not encapsulate the logic in get_image() because too much code (like dd if=...) expects to work with the file instead of url. And use get_image would lead to repeated data reloads from url. Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade |

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread Bastian Bittorf
* ad...@yapic.net [04.07.2016 17:27]: > +wget_if_URL(){ > + local url="$1" > + local url_repl_file="/tmp/sysupgrade-URL.bin" empty line here > + case "$url" in > + http://*|https://*|ftp://*) break ;; > + *) return 1 ;; > + esac empty line here > + r

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread adron
From: Sergey Sergeev I did not encapsulate the logic in get_image() because too much code (like dd if=...) expects to work with the file instead of url. And use get_image would lead to repeated data reloads from url. Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade |

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread adron
From: Sergey Sergeev I did not encapsulate the logic in get_image() because too much code (like dd if=...) expects to work with the file instead of url. And use get_image would lead to repeated data reloads from url. Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade |

Re: [LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread Felix Fietkau
On 2016-07-04 12:42, ad...@yapic.net wrote: > From: Sergey Sergeev > > I did not encapsulate the logic in get_image() because too much code > (like dd if=...) expects to work with the file instead of url. And > use get_image would lead to repeated data reloads from url. > > Signed-off-by: Sergey

[LEDE-DEV] [PATCH] base-files: sysupgrade. Added the ability to use URL as source

2016-07-04 Thread adron
From: Sergey Sergeev I did not encapsulate the logic in get_image() because too much code (like dd if=...) expects to work with the file instead of url. And use get_image would lead to repeated data reloads from url. Signed-off-by: Sergey Sergeev --- package/base-files/files/sbin/sysupgrade |