Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-22 Thread Bastian Bittorf
* Chris Blake [22.10.2016 20:39]: > +OVERLAY="$(cat /proc/mounts | grep ' /overlay ' 2>/dev/null)" fix this line: http://porkmail.org/era/unix/award.html bye, bastian ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/ma

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-22 Thread Chris Blake
Forgive me as I forgot the v3 in the patch header. Previous patch discussion was at http://lists.infradead.org/pipermail/lede-dev/2016-October/003473.html - Chris Blake ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/m

[LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-22 Thread Chris Blake
Currently the reset script will try to run jffs2reset on boards that are running a rw rootfs, such as ext4. This will cause jffs2reset to fail and the board to never reboot while the LED blinks until a manual reboot. This commit does two different things: 1. Disables reset on boards that do not ha

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-20 Thread Karl Palsson
It used to only do the sync+reboot for button presses less than 1 second. jffs2reset and reboot for button presses longer than 5 seconds, and _nothing_ for presses between 1 and 5 seconds. (Potentially leaving room for someone else to add some other hook, but realistically just useless) I noticed

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Chris Blake
Bastian, I will get that revised and push out a v2 of this patch. Thanks. On Wed, Oct 19, 2016 at 3:04 PM, Bastian Bittorf wrote: > * Chris Blake [19.10.2016 21:57]: >> + OVERLAY="$(cat /proc/mounts | grep ' /overlay ' 2>/dev/null)" > > please change to: > OVERLAY="$( grep ' /overlay ' /pro

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Chris Blake
Rafal, I am not sure I see the issue you are mentioning. The patch's goal is to disable the "reset" feature for devices that do not have an overlay, and instead just reboot the device. This patch does that, and was tested on an ar71xx and x86_64 ext4 platform. Regards, Chris Blake On Wed, Oct 19

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Mathias Kresin
19.10.2016 16:54, Chris Blake: Currently the reset script will try to run jffs2reset on boards that are running a rw ext4 or other rootfs, which will then cause jffs2reset to fail and the board to never reboot. This change ensures that jffs2reset is only ran if an overlay is mounted. Signed-off-

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Rafał Miłecki
On 19 October 2016 at 16:54, Chris Blake wrote: > Currently the reset script will try to run jffs2reset on boards that are > running a rw ext4 or other rootfs, which will then cause jffs2reset to > fail and the board to never reboot. This change ensures that jffs2reset > is only ran if an overlay

Re: [LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Bastian Bittorf
* Chris Blake [19.10.2016 21:57]: > + OVERLAY="$(cat /proc/mounts | grep ' /overlay ' 2>/dev/null)" please change to: OVERLAY="$( grep ' /overlay ' /proc/mounts )" bye, bastian ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.in

[LEDE-DEV] [PATCH] base-files: ensure reset only works if an overlay exists

2016-10-19 Thread Chris Blake
Currently the reset script will try to run jffs2reset on boards that are running a rw ext4 or other rootfs, which will then cause jffs2reset to fail and the board to never reboot. This change ensures that jffs2reset is only ran if an overlay is mounted. Signed-off-by: Chris Blake --- package/bas